Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Test the kedge build functionality #308

Closed
2 tasks
surajssd opened this issue Oct 4, 2017 · 8 comments
Closed
2 tasks

Test the kedge build functionality #308

surajssd opened this issue Oct 4, 2017 · 8 comments
Assignees
Milestone

Comments

@surajssd
Copy link
Member

surajssd commented Oct 4, 2017

Once #295 is merged, write tests to see if the kedge build functionality is valid.

TODO:

  • See if the image is built
  • See if the image is pushed to docker registry

Above things will be again done by using docker client libs

@ashetty1
Copy link
Collaborator

ashetty1 commented Oct 9, 2017

Picking this up if nobody is working on this yet.

@ashetty1 ashetty1 self-assigned this Oct 10, 2017
@kadel kadel added this to the 0.4.0 milestone Oct 10, 2017
@ashetty1
Copy link
Collaborator

@surajssd How do you think we should manage the authentication bit for pushing images in test scripts. Any ideas?

@surajssd
Copy link
Member Author

@ashetty1 maybe spin up a local docker registry and then try to push the image to that registry?

@ashetty1
Copy link
Collaborator

@surajssd have something like this now: https://gist.github.com/ashetty1/7f8f3832bebae9f9bcdf50466c6fadd0

Where would you like to have it reside?

@surajssd
Copy link
Member Author

@ashetty1

Where would you like to have it reside?

I think along with e2e tests

Please send a PR that way it is easier to check and test!

@kadel kadel modified the milestones: 0.6.0, 0.7.0 Dec 13, 2017
@kadel
Copy link
Member

kadel commented Dec 13, 2017

@ashetty1 what is state of this?

@ashetty1
Copy link
Collaborator

@kadel reviews done. Waiting to be merged: #381

@kadel
Copy link
Member

kadel commented Jan 3, 2018

closing, as this is done

@kadel kadel closed this as completed Jan 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants