Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

make e2e tests not run in verbose mode #379

Open
surajssd opened this issue Oct 23, 2017 · 5 comments
Open

make e2e tests not run in verbose mode #379

surajssd opened this issue Oct 23, 2017 · 5 comments

Comments

@surajssd
Copy link
Member

Based on the discussion here, we should move from verbose mode of running e2e tests to running tests in normal mode. We don't necessarily need verbose because golang test suite will dump the output of the failed test anyway if any test fails.

@kadel
Copy link
Member

kadel commented Oct 24, 2017

big +1
it is impossible to find anything useful in current output.
verbose output should be dumped only if there is an error

@cdrage
Copy link
Collaborator

cdrage commented Nov 7, 2017

PR updated here: #388

@kadel
Copy link
Member

kadel commented Jan 11, 2018

semaphore e2e tests are still verbose.
It is really hard to find out why the test is failing in all that input.

I really like go test behavior, if everything is ok, it just prints OK and nothing more. If the test fails that verbose output is shown, but only for failed tests.
We should do the same for our e2e tests

@ashetty1
Copy link
Collaborator

@kadel I think the verbose mode in CI is intentional. Could be changed if you'd like.

@kadel
Copy link
Member

kadel commented Jan 11, 2018

We should also clean up errors, that are actually not errors, like showing

0: dial tcp 192.168.122.112:31850: getsockopt: connection refused
    	e2e_test.go:217: error while making http request "http://192.168.122.112:31850" for service "web:80", err: Get http://192.168.122.112:31850: dial tcp 192.168.122.112:31850: getsockopt: connection refused

while waiting for pods to come up. Technically this is not error. An error means that something went wrong that is permanent and it can't be recovered from. This is error only when it times up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants