Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

fix(e2e tests): make test compile #372

Merged
merged 1 commit into from
Oct 23, 2017

Conversation

surajssd
Copy link
Member

@surajssd surajssd commented Oct 23, 2017

e2e tests failed due to wrong import of the test dependency and
since the test starting script was buggy, the tests seemed to pass
even if they were failing, now the import has been fixed.

Fixes #371

e2e tests failed due to wrong import of the test dependency and
since the test starting script was buggy, the tests seemed to pass
even if they were failing, now the import has been fixed.
@kadel
Copy link
Member

kadel commented Oct 23, 2017

this solves the compilation issue, but tests are still failing

    	e2e_test.go:195: error while making http request "http://192.168.99.100:30123" for service "wordpress:8080", err: Get http://192.168.99.100:30123: dial tcp 192.168.99.100:30123: getsockopt: connection refused
    	e2e_test.go:200: "wordpress:8080" is running!
    	e2e_test.go:394: Successfully pinged all endpoints!
    	e2e_test.go:219: successfully deleted namespace: "customvol"
PASS
ok  	github.com/kedgeproject/kedge/tests/e2e	361.153s
healthchecks   database-2086584510-30jjt   1/1       Terminating   0         2m
healthchecks   web-344968111-s4p3q   1/1       Terminating   0         2m
healthchecks   web-344968111-ks5pq   1/1       Terminating   0         2m
./tests/e2e/run_e2e.sh: line 45: kill: (12282) - No such process

@surajssd
Copy link
Member Author

@kadel tests passed:

ok  	github.com/kedgeproject/kedge/tests/e2e	361.153s

at the end the script tries to kill the already exited process, which @ashetty1 is fixing in #364

@kadel
Copy link
Member

kadel commented Oct 23, 2017

and this error is also OK? e2e_test.go:195: error while making http request "http://192.168.99.100:30123" for service "wordpress:8080", err: Get http://192.168.99.100:30123: dial tcp 192.168.99.100:30123: getsockopt: connection refused

@kadel
Copy link
Member

kadel commented Oct 23, 2017

merging this so at least we fix compilation error

@kadel kadel merged commit 72f1ec6 into kedgeproject:master Oct 23, 2017
@surajssd
Copy link
Member Author

@kadel yep those are okay the connection is refused until the healthchecks pass, and the curl is tried until certain timeout, after that the test is declared as failed.

@kadel
Copy link
Member

kadel commented Oct 23, 2017

Then those errors shouldn't be displayed, as they are not actually errors.

The output from e2e is a bit confusing, as it includes a lot of information that doesn't say anything useful :-(

@surajssd
Copy link
Member Author

surajssd commented Oct 23, 2017

@kadel the decision to run tests in verbose mode was made here #77 (comment)

I am of opinion to run tests in normal mode though!

@kadel
Copy link
Member

kadel commented Oct 23, 2017

I am of opinion to run tests in normal mode though!

I have the same opinion. If tests are running successfully, we don't need any output. just OK, or PASS is ok.

Only if the test fails then it should display as much info as it can.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All e2e tests are broken - semaphore is showing false positives
2 participants