This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Cleanup and reorganize examples #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
concaf
reviewed
Aug 16, 2017
examples/wordpress/wordpres.yaml
Outdated
| @@ -0,0 +1,33 @@ | |||
| name: web | |||
There was a problem hiding this comment.
nit: typo in file name - s/wordpres.yaml/wordpress.yaml
|
Looks fine to me, will let @pradeepto do an LGTM wrt UX and structure. |
cdrage
suggested changes
Aug 16, 2017
docs/examples/basic/README.md
Outdated
| targetPort: 80 | ||
| ``` | ||
|
|
||
| It is list of [service spec](https://kubernetes.io/docs/api-reference/v1.6/#servicespec-v1-core), which means that each app can have multiple services defined. Also see that ports are defined in the `services` field and not in the containers. You can choose to declare ports in the `containers.ports` as well but it is not required. |
There was a problem hiding this comment.
it is a list of
can contain multiple services defined
Ports are defined in the services filed but not in the container field
declare ports in
as well, but it is not required
examples/guestbook-demo/README.md
Outdated
|
|
||
| # Guestbook demo | ||
|
|
||
| This is demo application to show 3 tier web application. |
There was a problem hiding this comment.
this is a demo application to show a 3-tier web application
examples/guestbook-demo/README.md
Outdated
| This is demo application to show 3 tier web application. | ||
|
|
||
|
|
||
| You can find more information https://github.com/kadel/guestbook-demo |
There was a problem hiding this comment.
You can find more information at
examples/wordpress/README.md
Outdated
|
|
||
| `mariadb.yaml` defines two Secrets (`database-root-password` and `database-user-password`) and one ConfigMap (`mariadb`). | ||
| `wordprss.yaml` gets information on how to connect to database from `database-user-password` Secret and `mariadb` ConfigMap. |
|
thx @cdrage for looking at this everything that you pointed out should be fixed |
cdrage
approved these changes
Aug 16, 2017
|
LGTM. Merge whenever! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #136 this splits examples directory into two parts.
docs/examples
Usage (spec) examples that are just showcasing Kedge features.
Those examples can sometimes use unnecessarily complicated constructs to highlight some of the Kedge features.
/examples
This should contain only real-world examples. It will become a library of Kedge Apps, where users can learn best practices from real examples. Those examples should use just constructs that make sense for given examples and keep the definition as clean as possible.