add local testing of json schema generation

[surajssd]

No description provided.

[ashetty1]

Tested it and it works

[surajssd]

@ashetty1 thanks!

[surajssd]

@kadel ping

[cdrage]

IMO this should not be included.

This suddenly uses a Docker container.

Similar to how we have integration tests / unit tests / cmd tests separated into their separate commands.

[surajssd]

Is it not safe to assume that the kedge developers have docker installed locally?

[cdrage]

no, it's not safe, and tests should be ran separately... testing json-schema-generation should be separate just like test-unit, test-ci, test-cmd, etc.

[surajssd]

done changes as requested!

[surajnarwade]

if I run it locally, I get following error:

$ make test-jsonschema-generation 
docker run -v `pwd`/pkg/spec/spec.go:/data/spec.go:ro,Z surajd/kedgeschema
+ curl https://raw.githubusercontent.com/kedgeproject/json-schema-generator/master/scripts/k8s-release
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    12  100    12    0     0     12      0  0:00:01 --:--:--  0:00:01    22
+ curl -O https://raw.githubusercontent.com/kubernetes/kubernetes/release-1.7/api/openapi-spec/swagger.json
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1776k  100 1776k    0     0    423      0  1:11:40  1:11:36  0:00:04 1023k
+ curl -O https://raw.githubusercontent.com/kedgeproject/kedge/master/pkg/spec/spec.go
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0Warning: Failed to create the file spec.go: Read-only file system
 25  7696   25  1925    0     0   1925      0  0:00:03 --:--:--  0:00:03  3493
curl: (23) Failed writing body (0 != 1925)
Makefile:125: recipe for target 'test-jsonschema-generation' failed
make: *** [test-jsonschema-generation] Error 23

[surajnarwade]

using sudo in travis will work (for docker)

[surajssd]

@surajnarwade

if I run it locally, I get following error:

for some reason curl seemed to fail in there

using sudo in travis will work (for docker)

yes added sudo in front of docker command and also added sudo: required in travis config file

[cdrage]

having anything "sudo" within Makefile is really bad...

Please remove sudo! If a user wishes to run test-jsonschema-generation they can use make test-jsonschema-generation

see other comment, after adding:

sudo: required

services:
  - docker

you wont need to sudo the docker command anyways.

[surajssd]

resolved!

[cdrage]

will need to add docker as a service to here too:

sudo: required

services:
  - docker

[surajssd]

done, thanks!

[cdrage]

Other than SemaphoreCI test failing, LGTM!