This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
remove envFrom expansion support #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
force-pushed
the
remove-envfrom
branch
2 times, most recently
from
da28d4a
to
2b9f7d5
Compare
|
woah |
|
LGTM |
`envFrom` support was added to Kubernetes in 1.6 so we added support for it's expansion into normal env var for folks on older version of cluster. But this is no longer needed, since majority of folks are on cluster version >= 1.6.
surajssd
force-pushed
the
remove-envfrom
branch
from
2b9f7d5
to
59e8745
Compare
|
ping @kadel @containscafeine |
concaf
approved these changes
Oct 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envFromsupport was added to Kubernetes in 1.6 so we added supportfor it's expansion into normal env var for folks on older version of
cluster. But this is no longer needed, since majority of folks
are on cluster version >= 1.6.
Fixes #248