This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
always populate service port name #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Service port name was only populated when, there were more than one ports in the service, but now the port names will be always be populated if none given by the user. When you create a service with just one service and expose it with a OpenShift route, and later in time if you add one more port to the exposed service, the OpenShift route will send traffic to all the ports of service. To avoid that naming the port from the first time is necessary.
concaf
approved these changes
Oct 26, 2017
kadel
approved these changes
Oct 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service port name was only populated when, there were more than one
ports in the service, but now the port names will be always be
populated if none given by the user.
When you create a service with just one service and expose it with a
OpenShift route, and later in time if you add one more port to the
exposed service, the OpenShift route will send traffic to all the
ports of service. To avoid that naming the port from the first time
is necessary.
Fixes #323