Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Vendor update 3.7.0 #506

Merged
merged 2 commits into from Dec 21, 2017
Merged

Conversation

surajssd
Copy link
Member

@surajssd surajssd commented Dec 4, 2017

No description provided.

@cdrage
Copy link
Collaborator

cdrage commented Dec 4, 2017

Tests failed :(

@surajssd surajssd force-pushed the vendor-update-3.7.0 branch 2 times, most recently from 000c077 to ad7cf0a Compare December 5, 2017 08:56
@kadel
Copy link
Member

kadel commented Dec 11, 2017

We need to properly test this with OpenShift.
To be honest I don't trust our e2e tests :-(

@surajssd
Copy link
Member Author

@kadel what's decided on this? We don't want to remain behind in doing vendor updates because lot of these upstream dependencies are changing location and the way they are placed accordingly we have to make changes to place where we are importing from, so we should not wait for too long where it becomes harder for us to update vendor like it happened in kompose.

Why fear of failure we can always fix it when there are problems we encounter?

@kadel
Copy link
Member

kadel commented Dec 21, 2017

That still doesn't mean that we can merge something with test failing or without testing it first.

@surajssd surajssd merged commit a71b1b3 into kedgeproject:master Dec 21, 2017
@kadel
Copy link
Member

kadel commented Dec 21, 2017

hmm, that is weird, @surajssd did you made changes to commits before merging this?

@surajssd
Copy link
Member Author

@kadel yep rebased on master and made sure tests pass locally

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants