add vendor script to the commit #507
Conversation
| @@ -150,7 +150,7 @@ make vendor-update | |||
| 4. Commit updated glide files and vendor | |||
|
|
|||
| ```bash | |||
| git add glide.yaml glide.lock vendor | |||
| git add glide.yaml glide.lock scripts/vendor-openshift.sh vendor | |||
There was a problem hiding this comment.
Like I mentioned before, wouldn't this all be easier just to do a git add . and add a note here not not include and .go changes?
There was a problem hiding this comment.
I think that listing files explicitly like this is much safer.
There was a problem hiding this comment.
Whenever someone is updating the vendor using our make commands, then would it be required to vendor the scripts/vendor-openshift.sh script? They will not be making any changes to that script, only to glide.* and to the vendor directory. Do we need this at all?
|
@containscafeine yes we need it, see this example for some reference https://github.com/kedgeproject/kedge/pull/506/files#diff-4e4a5d0cc48e6822f990cad4695eb90eR15 |
|
@containscafeine @cdrage I think both of yours questions have been answered, can I merge this one? |
|
TIMEOUT - this is small documentation change so I'm merging this. |
No description provided.