Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes (some critical) and improvements #7

Merged
merged 7 commits into from Sep 6, 2020
Merged

Fixes (some critical) and improvements #7

merged 7 commits into from Sep 6, 2020

Conversation

CristiFati
Copy link
Contributor

@CristiFati CristiFati commented Jun 24, 2019

The details (and a POC) can be found at [SO]: How to connect to WiFi network using Python 3? (@CristiFati's answer).

Commit (by index) details (some of them):

  • 0 - (critical) Fixed the 87 error (at least in my case (xml profile), but I don't see why it wouldn't work for profile paths (as long as they exist :) ))
  • 3 - (critical) defining a 2 argument callback (as specified in MS docs) yields TypeError. Also as a side note regarding the context (affected by other commits as well): without it, the whole callback mechanism is useless, unless the only goal is to display real-time data
  • 5 - Not including the underlying error code in the exception (or including it in the string arg) makes the exception almost useless. Also, I think that the error code should come before the string, but there was a case with the current configuration, so I kept consistency

As I specified in some commit messages, some bugs are extremely likely to be encountered in other places as well, but I didn't invest time to (look for and) fix them
Also, the fixes are simple (and common sense), so didn't invest time (again) in tests

There are many other improvements that could be done(e.g.: functions having an interface as an argument and only using its guid).

Final note: I see a 3 years silence period. Is this module dead? Cause as far as I used it, it seems pretty nice, and a shallow search didn't reveal any other that works on Win.

@kedos kedos merged commit b492107 into kedos:master Sep 6, 2020
@CristiFati
Copy link
Contributor Author

Hello @kedos: Could you update a new version on PyPI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants