Fixes (some critical) and improvements #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The details (and a POC) can be found at [SO]: How to connect to WiFi network using Python 3? (@CristiFati's answer).
Commit (by index) details (some of them):
As I specified in some commit messages, some bugs are extremely likely to be encountered in other places as well, but I didn't invest time to (look for and) fix them
Also, the fixes are simple (and common sense), so didn't invest time (again) in tests
There are many other improvements that could be done(e.g.: functions having an interface as an argument and only using its guid).
Final note: I see a 3 years silence period. Is this module dead? Cause as far as I used it, it seems pretty nice, and a shallow search didn't reveal any other that works on Win.