Merge pyproject.toml files for starters #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
3 tasks
ankatiyar
approved these changes
Oct 24, 2023
SajidAlamQB
approved these changes
Oct 24, 2023
DimedS
deleted the
2975-merge-pyprojecttoml-files-for-starters-in-line-with-python-src-layout
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes the following changes:
pyproject.tomlfiles for starters in core folder. The secondpyproject.tomlfile has been removed.requirements.txtfile has been relocated to one level up.README.mdfile to align it with the main Kedro project template.Tested:
pip install git+https://github.com/kedro-org/kedro.git@develop
kedro new --starter git+https://github.com/kedro-org/kedro-starters.git --directory spaceflights-pandas --checkout 2975-merge-pyprojecttoml-files-for-starters-in-line-with-python-src-layout
works well, then 'pip install .' works well also, previously was a problem in requirements.txt with:
git+https://github.com/kedro-org/kedro-viz.git@main#egg=kedro-viz&subdirectory=package
changed it to:
kedro-viz @ git+https://github.com/kedro-org/kedro-viz.git@main#subdirectory=package