Update all readmes #185
Merged
Update all readmes #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com>
stichbury
reviewed
Nov 22, 2023
There was a problem hiding this comment.
I made a commit to this branch to change the READMEs. I removed the content about the example code added by tools for now as we discussed it in our docs meeting. It will come back in some form but we decided we need good separation between starters and the code added by tools, so I need to write this/see it written and then add a sentence or two to each starter where needed to explain. Or maybe just link to the framework docs. So this is still to come but you can do that in a separate PR if you want to merge this one.
spaceflights-pyspark-viz/{{ cookiecutter.repo_name }}/README.md
Outdated
Show resolved
Hide resolved
stichbury
reviewed
Nov 22, 2023
stichbury
reviewed
Nov 22, 2023
spaceflights-pyspark-viz/{{ cookiecutter.repo_name }}/README.md
Outdated
Show resolved
Hide resolved
stichbury
approved these changes
Nov 22, 2023
merelcht
commented
Nov 23, 2023
merelcht
commented
Nov 23, 2023
spaceflights-pyspark-viz/{{ cookiecutter.repo_name }}/README.md
Outdated
Show resolved
Hide resolved
merelcht
commented
Nov 23, 2023
spaceflights-pyspark-viz/{{ cookiecutter.repo_name }}/README.md
Outdated
Show resolved
Hide resolved
merelcht
commented
Nov 23, 2023
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
merelcht
commented
Nov 23, 2023
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
|
Thanks for the changes @merelcht -- all look good to me. I committed them. |
noklam
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes kedro-org/kedro#3111
I made all spaceflight starter README.md files consistent. And updated any outdated info.
Checklist