-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-2556] Add CircleCI config #24
Conversation
2f7395b
to
9270fe3
Compare
…. remove features from individual directories
f9b1978
to
e827d31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Just some minor questions 🙂
build: | ||
jobs: | ||
- security_scan | ||
- e2e_38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these tests be run on Windows as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that's a good point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting windows to work was really fiddly so I'll defer it to a separate ticket, and reap the benefits of having some CI working in the meantime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, that sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, I'm really pleased we have it 💯 Just a few comments/ideas/questions but generally looks great.
-
(Not for this PR) Should we have a
develop
branch for kedro-starters? This could have analogous CI checks against kedro'sdevelop
branch? So we can continue developing and testing against 0.18 starters (e.g. following breaking changes toConfigLoader
, I can no longer work off kedro'sdevelop
and make a new project from a starter, only an empty kedro project). -
Possible extra behave tests to run:
kedro ipython
loads up ok;kedro test
runs? -
Where is
I have installed the Kedro project's dependencies
defined? Do we need to be running each test in its own environment to make sure thatkedro install
for one starter doesn't interfere with another?
In terms of splitting things up, just thinking out loud here... I guess we have a 3 dimensional space here of environment (e.g. Python 3.7) x starter (e.g. spaceflights) x feature (e.g. lint). For CircleCI it makes sense to split up builts by environment, so then the only option is whether they should be broken down further, either by starter or by feature. Given the current grouping is done by feature, that would seem like the natural way to split it. i.e. you would have one build for each of:
- Python 3.7,
behave lint
- Python 3.7,
behave run
- Python 3.8,
behave lint
- Python 3.8,
behave run
- etc.
I think it's possible to generate this sort of matrix of builds on CircleCI. But I don't think it's too bad just having them grouped as they currently are.
I guess the alternative way of grouping would be to group feature files by starter rather than sort of test. Maybe it's even possible to just make one such templated file and then provide the starter name as an argument:
and then do |
Mm in the past we just had a separate branch
I kinda prefer the tests to only check the critical workflow
I thought this was already happening but I'll double check. And yeah I thought about splitting by lint_py37, run_py37 etc, might just change it to that for clarity. |
1b565f3
to
0fdf5fb
Compare
Long-overdue enabling of CI.
Had to dig out https://github.com/quantumblacklabs/private-kedro/issues/790 to make sense in my head what we're doing..
kedro
master
should be in sync with startersmaster
.features
...TODO:
astro-iris
starter in e2e testing.