Skip to content

Commit

Permalink
Fix Safari blank page when clicking on modular pipelines (#1488)
Browse files Browse the repository at this point in the history
* Filter out undefined edges

Signed-off-by: Vladimir <vladimir_nikolic@external.mckinsey.com>

* Update RELEASE.md

---------

Signed-off-by: Vladimir <vladimir_nikolic@external.mckinsey.com>
Co-authored-by: Tynan DeBold <thdebold@gmail.com>
  • Loading branch information
vladimir-mck and tynandebold committed Aug 16, 2023
1 parent d04df85 commit 50ebfe6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Please follow the established format:
- Include the ID number for the related PR (or PRs) in parentheses
-->


# Release 6.3.5

## Major features and improvements
Expand All @@ -18,6 +19,7 @@ Please follow the established format:
- Fix broken SVG/PNG exports in light theme. (#1463)
- Fix dataset and global toolbar error with standalone React component (#1351)
- Fix `ImportError` as kedro-datasets is now lazily loaded (#1481).
- Fix issue of encountering a blank page in Safari when interacting with modular pipelines. (#1488)

# Release 6.3.4

Expand Down
5 changes: 4 additions & 1 deletion src/components/flowchart/draw.js
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,10 @@ export const drawEdges = function (changed) {
const updateEdges = this.el.edges;
const enterEdges = this.el.edges.enter().append('g');
const exitEdges = this.el.edges.exit();
const allEdges = this.el.edges.merge(enterEdges).merge(exitEdges);
const allEdges = this.el.edges
.merge(enterEdges)
.merge(exitEdges)
.filter((edge) => edge);

if (changed('edges', 'focusMode', 'inputOutputDataNodes')) {
enterEdges.append('path');
Expand Down

0 comments on commit 50ebfe6

Please sign in to comment.