Fix/focus mode modular pipeline highlight #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cvetanka <cventanka_nechevska@external.mckinsey.com>
Signed-off-by: Cvetanka <cventanka_nechevska@external.mckinsey.com>
cvetankanechevska
requested review from
tynandebold,
rashidakanchwala,
Huongg and
Mackay031
tynandebold
approved these changes
Sep 30, 2022
src/actions/index.js
Outdated
|
|
||
| /** | ||
| * Update the value of the of the currently-active hovered node from focus mode | ||
| * @param {string|null} nodeHovered The node's unique identifier |
There was a problem hiding this comment.
Suggested change
| * @param {string|null} nodeHovered The node's unique identifier | |
| * @param {string|null} hoveredFocusMode The node's unique identifier |
There was a problem hiding this comment.
Please check my last commit for this fix. Thanks
There was a problem hiding this comment.
thanks @cvetankanechevska -- look's great!!! :)
nit - we can look at adding unit tests to actions, reducers, node-list and flowchart.
Signed-off-by: Cvetanka <cventanka_nechevska@external.mckinsey.com>
Signed-off-by: Cvetanka <cventanka_nechevska@external.mckinsey.com>
Signed-off-by: Cvetanka <cventanka_nechevska@external.mckinsey.com>
|
Hey @tynandebold and @rashidakanchwala I've added tests for the action, reducer and flowchart. Not sure about the test in the node-list component, since that action is already covered with the action and reducer tests. If you have any suggestions please let me know. |
Huongg
approved these changes
Oct 4, 2022
Signed-off-by: Cvetanka <cventanka_nechevska@external.mckinsey.com>
rashidakanchwala
approved these changes
Oct 4, 2022
comym
approved these changes
Oct 4, 2022
tynandebold
reviewed
Oct 4, 2022
RELEASE.md
Outdated
| @@ -20,6 +20,7 @@ Please follow the established format: | |||
| - Remove Tags field from dataset and parameter nodes when viewed in metadata panel. (#1100) | |||
| - Fix keyboard support for exporting experiment runs. (#1103) | |||
| - Fix `MemoryDataSet` not displaying on metadata panel. (#1113) | |||
| - Add hovering on the FocusModeIcon. (#1107) | |||
There was a problem hiding this comment.
Suggested change
| - Add hovering on the FocusModeIcon. (#1107) | |
| - Enhance display of the flowchart when hovering over the FocusMode icon. (#1107) |
There was a problem hiding this comment.
Thanks for this, I will change it.
|
Did I just mark this as resolved? If so, I apologise. |
Mackay031
approved these changes
Oct 4, 2022
Signed-off-by: Cvetanka <cventanka_nechevska@external.mckinsey.com>
cvetankanechevska
deleted the
fix/focus-mode-modular-pipeline-highlight
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #921
Development notes
Added one more boolean property to
createInitialPipelineState, to track when FocusModeIcon is hovered and create new action in the store for updating this value.For the style I reused the class we already have for when node is clicked and all other nodes in the flowchart are pushed in the background with some opacity (class:
pipeline-node--faded).QA notes
You can open the Gitpod link, and check the hover effect on FocusModeIcon in the left side node list.
Checklist
RELEASE.mdfile