Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sqlalchemy dependency #1222

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Pin sqlalchemy dependency #1222

merged 1 commit into from
Jan 17, 2023

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Jan 17, 2023

Signed-off-by: Merel Theisen merel.theisen@quantumblack.com

Description

Solves part of kedro-org/kedro#2202

Since a couple of days users who have kedro-viz installed see a message like this:

/Users/merel_theisen/Projects/kedro-viz/package/kedro_viz/models/experiment_tracking.py:16: MovedIn20Warning: Deprecated API features detected! These feature(s) are not compatible with SQLAlchemy 2.0. To prevent incompatible upgrades prior to updating applications, ensure requirements files are pinned to "sqlalchemy<2.0". Set environment variable SQLALCHEMY_WARN_20=1 to show all deprecation warnings.  Set environment variable SQLALCHEMY_SILENCE_UBER_WARNING=1 to silence this message. (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)

whenever they're running a Kedro command. This is annoying, distracting and can even seem intimidating to new users who don't know if this is an error or can be ignored.

Development notes

I've added an upper bound to the sqlalchemy dependency like suggested in the warning message. SQLAlchemy 2.0 hasn't been released yet, but when it is we should remove this upper bound again.

QA notes

NA

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants