Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt #1300

Merged
merged 1 commit into from Mar 28, 2023
Merged

Update requirements.txt #1300

merged 1 commit into from Mar 28, 2023

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Mar 28, 2023

Description

Fix kedro-org/kedro#2474

While kedro-viz works with SQLalchemy >=2.0, we shouldn't bump the lowerbound immediately, as many cannot upgrade directly (released 2 months ago). It also creates conflict with kedro directly because kedro has a pin with sqlalchemy~=1.2.

The better things to do is extend the upperbound but keep the lowerbound so it will continue to works with kedro. Any future upgrade in kedro that extend SQLalchemy support will work automatically.

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@noklam noklam merged commit 5897a33 into main Mar 28, 2023
4 checks passed
@noklam noklam deleted the fix-viz-dependency branch March 28, 2023 13:25
@tynandebold tynandebold mentioned this pull request Mar 30, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible versions of sqlalchemy between kedro[pandas]~=0.18 and kedro-viz~=6.0
3 participants