Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Safari blank page when clicking on modular pipelines #1488

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Fix Safari blank page when clicking on modular pipelines #1488

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6182af7
Filter out undefined edges
vladimir-mck Aug 15, 2023
0365157
Update RELEASE.md
vladimir-mck Aug 16, 2023
51e4fe4
Merge branch 'main' into bugfix/1462-safari-blank-page
tynandebold Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Please follow the established format:
- Use present tense (e.g. 'Add new feature')
- Include the ID number for the related PR (or PRs) in parentheses
-->

## Major features and improvements

- Add support for displaying dataset statistics in the metadata panel. (#1472)
Expand All @@ -17,6 +18,7 @@ Please follow the established format:
- Fix broken SVG/PNG exports in light theme. (#1463)
- Fix dataset and global toolbar error with standalone React component (#1351)
- Fix `ImportError` as kedro-datasets is now lazily loaded (#1481).
- Fix the issue of encountering a blank page in Safari when interacting with the modular pipeline. (#1462)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The # number in the bracket should be the PR number


# Release 6.3.4

Expand Down
5 changes: 4 additions & 1 deletion src/components/flowchart/draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,10 @@ export const drawEdges = function (changed) {
const updateEdges = this.el.edges;
const enterEdges = this.el.edges.enter().append('g');
const exitEdges = this.el.edges.exit();
const allEdges = this.el.edges.merge(enterEdges).merge(exitEdges);
const allEdges = this.el.edges
.merge(enterEdges)
.merge(exitEdges)
.filter((edge) => edge);

if (changed('edges', 'focusMode', 'inputOutputDataNodes')) {
enterEdges.append('path');
Expand Down