Chore/bump pydantic and fastapi #1539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Signed-off-by: CORP\iboeijen <inger.van.boeijen@sogeti.com>
Signed-off-by: CORP\iboeijen <inger.van.boeijen@sogeti.com>
IngerMathilde
force-pushed
the
chore/bump_pydantic_and_fastapi
branch
from
c198a46
to
658fb86
Compare
|
Tried looking at this a bit more, but this approach is not working well with the newest fastapi. So then one could support the new pydantic but not the new fastapi. Atleast this is how it is currently. Will close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on fdroesler pr (#1529), but with one important difference. Pydantic v2 is supported but not used by kedro viz. This simplifies the pr.
Development notes
This is just to show the idea behind it. Kind of unsure what is smart with adding tests with different environments etc.
QA notes
Checklist
RELEASE.mdfile