-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dataset factory patterns in Experiment Tracking #1588
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
87dd132
add dataset factory resolver
ravi-kumar-pilla 6d1ca97
fix lint errors
ravi-kumar-pilla 2447cc2
add release notes
ravi-kumar-pilla ddfe45c
Merge branch 'main' of https://github.com/kedro-org/kedro-viz into fi…
ravi-kumar-pilla 4a8fe57
merge main
ravi-kumar-pilla 48c1039
fix lint
ravi-kumar-pilla 9f10bc0
add pytest for resolve dataset factory patterns
ravi-kumar-pilla 1bf29d0
Merge branch 'main' of https://github.com/kedro-org/kedro-viz into fi…
ravi-kumar-pilla 7588265
modify release statement
ravi-kumar-pilla 59f218f
Merge branch 'main' into fix/et-dataset_factory
ravi-kumar-pilla ae52534
add comments based on PR review
ravi-kumar-pilla 3bd3e04
Merge branch 'fix/et-dataset_factory' of https://github.com/kedro-org…
ravi-kumar-pilla File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might catch other exceptions. You could try
if hasattr(pipeline, 'data_set
):`