Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Kedro Viz timeout #1803

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Increase Kedro Viz timeout #1803

merged 6 commits into from
Mar 19, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

Description

Resolves #1768

Development notes

  • Starting Kedro Viz might take more than 60sec in few cases where users receive a timeout error and are unable to proceed further
  • To resolve the issue temporarily, we are increasing the timeout to 10min (which might be a rare case).

NOTE: Ideally we would like kedro-viz to load within 60sec and we are working on few tickets which would help us to acheive a permanent solution in near future.

QA notes

  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla
increase viz timeout
f653fd6 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
fix lint and add release note
e011dbd 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review March 14, 2024 18:29
@ravi-kumar-pilla
test comment to check unit test
22c69f5 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
test comment to check unit test
539de21 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
reduce mock timeout
e2920ad 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
NeroOkwa
NeroOkwa approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@NeroOkwa NeroOkwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (from a product perspective)

rashidakanchwala
rashidakanchwala approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks :)

@astrojuanlu astrojuanlu mentioned this pull request Mar 19, 2024
Closed
@ravi-kumar-pilla ravi-kumar-pilla merged commit ec3540e into main Mar 19, 2024
14 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/temp-timeout-inc branch March 19, 2024 19:38
@jitu5 jitu5 mentioned this pull request Apr 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu left review comments

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@NeroOkwa NeroOkwa NeroOkwa approved these changes

@SajidAlamQB SajidAlamQB Awaiting requested review from SajidAlamQB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kedro viz > 6.5.0 times out when working with Spark
4 participants
@ravi-kumar-pilla @astrojuanlu @rashidakanchwala @NeroOkwa