Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TRANSCODING_SEPARATOR import errors #1866

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Apr 17, 2024

Description

Resolves #1865

Development notes

With the PR - https://github.com/kedro-org/kedro/pull/3812/files
TRANSCODING_SEPARATOR has been moved from kedro/pipeline/pipeline.py to kedro/pipeline/_transcoding.py. Since kedro-viz imports these, we need to handle the import error before the latest kedro release.

QA notes

  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review April 17, 2024 02:14
@ravi-kumar-pilla ravi-kumar-pilla requested review from SajidAlamQB and removed request for astrojuanlu April 17, 2024 02:14
@rashidakanchwala rashidakanchwala merged commit 068f9b6 into main Apr 17, 2024
16 checks passed
@rashidakanchwala rashidakanchwala deleted the fix/transcoding branch April 17, 2024 09:28
@jitu5 jitu5 mentioned this pull request Apr 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TRANSCODING_SEPARATOR import errors
4 participants