-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This PR add modular-spaceflights repository as a demo-project within Kedro-Viz #696
Conversation
not sure if it matters but the images in the readmes will be broken since they point to the .tours directory which wasn't inlcuded |
@datajoely oh yea good point. Let me fix it. I excluded the |
Does this do anything other than add in the |
@tynandebold it doesn't do anything yet. Just add the demo project file. More followup PRs coming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just tried this out and seems to run end to end but I'm a bit confused about the requirements files:
- What is
demo_requirements.txt
for? It giveskedro==0.17.5
, which won't actually work for this project that usessum(pipelines)
- we needkedro==0.17.6
as in requirements.in. - Should we remove
kedro-telemetry
from the requirements? - Should we remove
kedro-viz
from the requirements? So that it doesn't install off PyPI when we want to use the localkedro-viz
Also, do we want some mock data in there as well? I think @studioswong had some here, but we can always add it on later. We'll need to change the gitignore and dockerignore accordingly.
@AntonyMilneQB Ah, the Good point about kedro-viz and kedro-telemetry; I will remove them. However, I think since this is will be used through running Regarding test data, I thought we would want it on a shared, neutral environment like a gitpod? If not, I can include the data I have locally which is what we currently see on demo.kedro.org |
@AntonyMilneQB I have updated it with the test data and remove kedro-viz as well as kedro-telemetry as dependency. |
@limdauto think it might be good to also add in a note in either the |
@studioswong yep as mentioned I will follow up with another PR. I think it would be good to review that separately. I just want to commit the code as-is in this PR so we don't have to verify anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting this up!
One thing - it would be nice to name the demo project with a more specfic name such as demo-modular-spaceflights
so it's easier to reference that to the modular spaceflight project.. Maybe one for your next PR
@studioswong interesting. I actually specifically changed it from modular-spaceflights to demo-project to make it a little less specific since we might deviate from that one and to make it clear that this is used to deploy demo.kedro.org. However, happy to change it in the next PR. |
My 2¢: I like the ambiguity of |
Agreed with @tynandebold on this - I'd keep it just as |
Though I guess the |
Description
As discussed, this would make it easier to:
Development notes
QA notes
Checklist
RELEASE.md
file