-
Notifications
You must be signed in to change notification settings - Fork 874
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make it possible to use Kedro after uninstalling Rich. (#3838)
* attempt to configure fallback logger Signed-off-by: lrcouto <laurarccouto@gmail.com> * Set up fallback for logging on the logging function itself Signed-off-by: lrcouto <laurarccouto@gmail.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Update kedro/logging.py Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> * Changes to rich variable on logging Signed-off-by: lrcouto <laurarccouto@gmail.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * attempt to configure fallback logger Signed-off-by: lrcouto <laurarccouto@gmail.com> * Set up fallback for logging on the logging function itself Signed-off-by: lrcouto <laurarccouto@gmail.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Update kedro/logging.py Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> * Changes to rich variable on logging Signed-off-by: lrcouto <laurarccouto@gmail.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * adapt default logging Signed-off-by: lrcouto <laurarccouto@gmail.com> * Update kedro/logging.py Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> * Create separate logging config file for rich Signed-off-by: lrcouto <laurarccouto@gmail.com> * Hello linter my old friend Signed-off-by: lrcouto <laurarccouto@gmail.com> * Alternative for rich in kedro ipython Signed-off-by: lrcouto <laurarccouto@gmail.com> * Remove unnecessary try/except block Signed-off-by: lrcouto <laurarccouto@gmail.com> * Update pyproject.toml Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> * Resolve merge conflict Signed-off-by: lrcouto <laurarccouto@gmail.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Fix config file paths Signed-off-by: lrcouto <laurarccouto@gmail.com> * Update kedro/ipython/__init__.py Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> * Update kedro/ipython/__init__.py Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> * Prevent kedro ipython from reimporting rich multiple times Signed-off-by: lrcouto <laurarccouto@gmail.com> * Logging config Signed-off-by: lrcouto <laurarccouto@gmail.com> * Change test config Signed-off-by: lrcouto <laurarccouto@gmail.com> * Remove ' yEs ' tests Signed-off-by: lrcouto <laurarccouto@gmail.com> * Tests to cover ipython changes Signed-off-by: lrcouto <laurarccouto@gmail.com> * Add test for import Signed-off-by: lrcouto <laurarccouto@gmail.com> * Ignore test coverage on import try/except Signed-off-by: lrcouto <laurarccouto@gmail.com> * Lint Signed-off-by: lrcouto <laurarccouto@gmail.com> * Unpin cookiecutter version Signed-off-by: lrcouto <laurarccouto@gmail.com> * Add changes to documentation Signed-off-by: lrcouto <laurarccouto@gmail.com> * Update RELEASE.md Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> * Change RICH variable name to RICH_INTALLED Signed-off-by: lrcouto <laurarccouto@gmail.com> * Add info about uninstalling rich on logging doc page Signed-off-by: lrcouto <laurarccouto@gmail.com> --------- Signed-off-by: lrcouto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
- Loading branch information
1 parent
8eff357
commit a53500a
Showing
13 changed files
with
118 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
include README.md | ||
include LICENSE.md | ||
include kedro/framework/project/default_logging.yml | ||
include kedro/framework/project/rich_logging.yml | ||
include kedro/ipython/*.png | ||
include kedro/ipython/*.svg | ||
recursive-include kedro/templates * |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
version: 1 | ||
|
||
disable_existing_loggers: False | ||
|
||
handlers: | ||
rich: | ||
class: kedro.logging.RichHandler | ||
rich_tracebacks: True | ||
# Advance options for customisation. | ||
# See https://docs.kedro.org/en/stable/logging/logging.html#project-side-logging-configuration | ||
# tracebacks_show_locals: False | ||
|
||
loggers: | ||
kedro: | ||
level: INFO | ||
|
||
root: | ||
handlers: [rich] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters