Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a manual test procedure for Jupyter Notebook workflows #2137

Closed
jmholzer opened this issue Dec 19, 2022 · 3 comments
Closed

Create a manual test procedure for Jupyter Notebook workflows #2137

jmholzer opened this issue Dec 19, 2022 · 3 comments
Labels
Component: Testing Issue/PR that addresses tests Should we delete?

Comments

@jmholzer
Copy link
Contributor

Description

Create a checklist for manually testing Jupyter Notebook workflows after making changes to Kedro's ipython module that covers common use cases.

Context

Currently, our unit and end-to-end tests do not cover some common workflows that users have with Jupyter Notebook.

This lets us break these workflows silently, as in #2060.

The core team agreed that end-to-end test cases for these workflows would be too fragile and would add a maintenance burden to our CI that is not justified by the number of changes we tend to make to ipython. Therefore, we should create a checklist of manual tests.

@merelcht
Copy link
Member

@noklam @lrcouto @AhdraMeraliQB since you've recently worked on Jupyter functionality, do you think we should still do this ticket?

@noklam
Copy link
Contributor

noklam commented Mar 12, 2024

@merelcht I read both issues and I don't know what do we need to manually test or why is it not possible to write automated tests?

We have made a lot of improvement to the ipython test suites and I think #3528 is still worth to do but not so urgent. e2e test for Notebook is not possible because it involves frontend logic, it should works for ipython at least to make sure the %load_node code is not completely broken.

I'd say go ahread and close this issue since we don't have any manual Notebook test since this issue created and it doesn't cause any problem. If there is a specific regression case we can discuss whether we can create automated test for it.

@noklam
Copy link
Contributor

noklam commented Mar 14, 2024

I take the liberty to close it, if there are disagreement feel free to re-open and comment on it.

@noklam noklam closed this as completed Mar 14, 2024
@noklam noklam reopened this Mar 14, 2024
@noklam noklam closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Testing Issue/PR that addresses tests Should we delete?
Projects
Archived in project
Development

No branches or pull requests

5 participants