Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to include visualized pipelines in the generated document #56

Closed
Minyus opened this issue Jul 14, 2019 · 8 comments
Closed

Option to include visualized pipelines in the generated document #56

Minyus opened this issue Jul 14, 2019 · 8 comments
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@Minyus
Copy link
Contributor

Minyus commented Jul 14, 2019

Description

An option to include the image of visualized pipelines in the Sphinx document generated by kedro build-docs command

Context

kedro-viz offers kedro viz command that can generate interactive visualized pipelines.

This visualization is very useful to explain to the stakeholders and it is even nicer to automate the manual operation to run kedro viz command, access the URL, take a screenshot, and paste it in the document.

![image](https://user-images.githubusercontent.com/33908456/61184262-542f8000-a67e-11e9-872e-3fa40e31b81c.png)

Possible Implementation

Programmatically communicate with the kedro_viz.server.

Possible Alternatives

Use a graph visualization tool such as graphviz.

@Minyus Minyus added the Issue: Feature Request New feature or improvement to existing feature label Jul 14, 2019
@Pet3ris
Copy link

Pet3ris commented Jul 15, 2019

Hi @Minyus, what sort of document would you like the image to be pasted in? Currently Kedro doesn't really produce any soft deliverables apart from perhaps the automated documentation. But providing the visualization there feels like a special case.

@Minyus
Copy link
Contributor Author

Minyus commented Jul 15, 2019

Hi @Pet3ris, it would be awesome if a visualized pipeline image file can be included in the HTML document automatically generated by kedro build-docs command.

Alternatively, would it be possible to output the pipeline graph data used by Kedro-Viz so that users can visualize the pipeline using common graph visualization tools such as GraphViz and Gephi?

@idanov
Copy link
Member

idanov commented Jul 16, 2019

Hi @Minyus, this sounds like a very interesting feature and I agree that it can be useful to add the pipeline graph to the docs. Since this feature request is more of a request to the kernel-viz plugin, rather than Kedro, maybe we can have the feature request posted https://github.com/quantumblacklabs/kedro-viz instead.

The implementation of this feature may prove to be quite involved, since it will require running the kedro-viz frontend in a headless browser and then take a screenshot there, which could be used for the docs. Given that this feature is nice to have and not very important for the user's workflow, but quite high on the effort, I will put it as low priority.

@Pet3ris
Copy link

Pet3ris commented Jul 16, 2019

@Minyus you can actually access the graph representation. kedro uses a hidden folder called .log or similar when sharing graph outputs with the graphviz so to answer your second question that's definitely possible.

Thoughts @idanov?

@Minyus
Copy link
Contributor Author

Minyus commented Jul 17, 2019

@Pet3ris Where can we find the hidden folder? Can we use it without running kedro viz command?

@tolomea
Copy link
Contributor

tolomea commented Jul 17, 2019

@Pet3ris that doesn't exist anymore
@Minyus If you'd like to see how Viz extracts the graph info from Kedro you can look here
https://github.com/quantumblacklabs/kedro-viz/blob/develop/package/kedro_viz/server.py#L53

@Minyus
Copy link
Contributor Author

Minyus commented Jul 17, 2019

@tolomea Noted. Thank you.

@lorenabalan
Copy link
Contributor

Hi @Minyus, I am going to close this issue as I have moved it under the kedro-viz umbrella - please see kedro-org/kedro-viz#31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request New feature or improvement to existing feature
Projects
None yet
Development

No branches or pull requests

6 participants