Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax the upper bound on jupyter_client ⬆️ #1322

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Relax the upper bound on jupyter_client ⬆️ #1322

merged 5 commits into from
Mar 8, 2022

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Mar 7, 2022 •
edited
Loading

Signed-off-by: Deepyaman Datta deepyaman.datta@utexas.edu

Description

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@datajoely datajoely mentioned this pull request Mar 7, 2022
Closed
@deepyaman deepyaman marked this pull request as ready for review March 7, 2022 20:19
@deepyaman
Relax the upper bound on jupyter_client ⬆️
54cc5f8 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Update requirements.txt
d21e112 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Update requirements.txt
e72bd22 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Update 02_tutorial_template.md
14bb56c 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@antonymilne antonymilne mentioned this pull request Mar 8, 2022
Closed
merelcht
merelcht approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @deepyaman ⭐ ⭐ ⭐

@merelcht merelcht linked an issue Mar 8, 2022 that may be closed by this pull request
Kedro build-reqs (pip-compile) dont find versions compatible with jupyter-client #1323
Closed
@lorenabalan lorenabalan merged commit 74fbd75 into kedro-org:main Mar 8, 2022
@deepyaman deepyaman deleted the patch-1 branch March 8, 2022 16:33
@datajoely
Copy link
Contributor

Annoyingly I think we need to do the same thing in the starters repo 🙈
https://github.com/kedro-org/kedro-starters/blob/1559a2a4750caed6d98c7e880bec70b5c71b43d4/astro-airflow-iris/%7B%7B%20cookiecutter.repo_name%20%7D%7D/src/requirements.txt

@deepyaman deepyaman mentioned this pull request Mar 8, 2022
Closed
@datajoely datajoely mentioned this pull request Mar 14, 2022
Closed
@merelcht merelcht mentioned this pull request Mar 22, 2022
Closed
AhdraMeraliQB pushed a commit that referenced this pull request Mar 30, 2022
@deepyaman @AhdraMeraliQB
Relax the upper bound on jupyter_client(#1322)
170cbff 
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
lvijnck pushed a commit to lvijnck/kedro that referenced this pull request Apr 7, 2022
@deepyaman @lvijnck
Relax the upper bound on jupyter_client(kedro-org#1322)
25bd127 
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenabalan lorenabalan lorenabalan approved these changes

@merelcht merelcht merelcht approved these changes

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

@idanov idanov Awaiting requested review from idanov

@antonymilne antonymilne Awaiting requested review from antonymilne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kedro build-reqs (pip-compile) dont find versions compatible with jupyter-client
4 participants
@deepyaman @datajoely @lorenabalan @merelcht