Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle plugin registration failure ContextualVersionConflict with log instead of raising error #1542

Merged
merged 26 commits into from
May 20, 2022
Merged

Handle plugin registration failure ContextualVersionConflict with log instead of raising error #1542

merged 26 commits into from
May 20, 2022

Commits on May 16, 2022

  1. ignore loading error 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 16, 2022
    Configuration menu
    Copy the full SHA
    72b84ca View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Move setuptools to pyproject.toml to align with PEP-518 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 17, 2022
    Configuration menu
    Copy the full SHA
    176f89f View commit details
    Browse the repository at this point in the history

  2. revert changes 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 17, 2022
    Configuration menu
    Copy the full SHA
    a19ee63 View commit details
    Browse the repository at this point in the history

  3. [WIP] - replace pkg_resource with importlib_metadata 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 17, 2022
    Configuration menu
    Copy the full SHA
    9d77ddd View commit details
    Browse the repository at this point in the history

  4. [WIP] - replace pkg_resource 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 17, 2022
    Configuration menu
    Copy the full SHA
    96500ad View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Replace entrypoint discovery with importlib 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 18, 2022
    Configuration menu
    Copy the full SHA
    cd45c3d View commit details
    Browse the repository at this point in the history

  2. Tidy up logging message, linting 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 18, 2022
    Configuration menu
    Copy the full SHA
    9ce96e9 View commit details
    Browse the repository at this point in the history

  3. small changes to tidy up the variables 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 18, 2022
    Configuration menu
    Copy the full SHA
    a0765e6 View commit details
    Browse the repository at this point in the history

  4. Add conditional import to fix importlib not available in python 3.7 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 18, 2022
    Configuration menu
    Copy the full SHA
    3c12bcc View commit details
    Browse the repository at this point in the history

  5. Fix test cases 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 18, 2022
    Configuration menu
    Copy the full SHA
    139a075 View commit details
    Browse the repository at this point in the history

  6. Update error message 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 18, 2022
    Configuration menu
    Copy the full SHA
    c4d655c View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Switch back to importlib_metadata and fix tests 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 19, 2022
    Configuration menu
    Copy the full SHA
    0ce181a View commit details
    Browse the repository at this point in the history

  2. add importlib as requirements 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 19, 2022
    Configuration menu
    Copy the full SHA
    3abfdc9 View commit details
    Browse the repository at this point in the history

  3. Fix test with py37 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 19, 2022
    Configuration menu
    Copy the full SHA
    200405b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/1487-contextualversionconflict-error-sto… 

    …p-kedro-running-when-dependency-clashes
    @noklam
    noklam committed May 19, 2022
    Configuration menu
    Copy the full SHA
    cd7ba3a View commit details
    Browse the repository at this point in the history

  5. Fix linting 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 19, 2022
    Configuration menu
    Copy the full SHA
    3d4aa55 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/fix/1487-contextualversionconfli… 

    …ct-error-stop-kedro-running-when-dependency-clashes' into fix/1487-contextualversionconflict-error-stop-kedro-running-when-dependency-clashes

Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 19, 2022
    Configuration menu
    Copy the full SHA
    4de3c11 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Apply changes from review 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 20, 2022
    Configuration menu
    Copy the full SHA
    91fb855 View commit details
    Browse the repository at this point in the history

  2. Refactor and fix wrong test 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 20, 2022
    Configuration menu
    Copy the full SHA
    3209dbe View commit details
    Browse the repository at this point in the history

  3. Fix some tests... should work now 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 20, 2022
    Configuration menu
    Copy the full SHA
    e20183c View commit details
    Browse the repository at this point in the history

  4. I forgot to put the setuptools back... 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 20, 2022
    Configuration menu
    Copy the full SHA
    d804e77 View commit details
    Browse the repository at this point in the history

  5. I have gone too far and removed a necessary dependency 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 20, 2022
    Configuration menu
    Copy the full SHA
    fc28f4a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fix/1487-contextualversionconflict-error-sto… 

    …p-kedro-running-when-dependency-clashes
    @noklam
    noklam committed May 20, 2022
    Configuration menu
    Copy the full SHA
    b3dbbab View commit details
    Browse the repository at this point in the history

  7. apply comments after reviews 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 20, 2022
    Configuration menu
    Copy the full SHA
    c61fd82 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/fix/1487-contextualversionconfli… 

    …ct-error-stop-kedro-running-when-dependency-clashes' into fix/1487-contextualversionconflict-error-stop-kedro-running-when-dependency-clashes

Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 20, 2022
    Configuration menu
    Copy the full SHA
    d7dff70 View commit details
    Browse the repository at this point in the history

  9. linting 

    Signed-off-by: noklam <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed May 20, 2022
    Configuration menu
    Copy the full SHA
    66a1b7d View commit details
    Browse the repository at this point in the history