Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only convert omegaconf DictConfig to primitive type for logging #2176

Merged
merged 7 commits into from Jan 10, 2023
Merged

Only convert omegaconf DictConfig to primitive type for logging #2176

merged 7 commits into from Jan 10, 2023

Commits on Jan 5, 2023

  1. Only convert omegaconf DictConfig to primitive type for logging 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    e2a00f5 View commit details
    Browse the repository at this point in the history

  2. Check if dealing with omegaconf dict before converting 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    ab003c1 View commit details
    Browse the repository at this point in the history

  3. Add test to check logging file is parsed correctly with omegaconfloader 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    67ff24d View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Merge branch 'main' into fix/omegaconfloader-logging

    @jmholzer
    jmholzer committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    e0678e1 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Address review suggestion 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    f8172a2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/omegaconfloader-logging

    @merelcht
    merelcht committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    8828bdd View commit details
    Browse the repository at this point in the history

  3. Fix lint 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    e87c320 View commit details
    Browse the repository at this point in the history