-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KEDRO_LOGGING_CONFIG
env variable to specific where to read logging.yml
#2535
Merged
noklam
merged 14 commits into
main
from
2206-make-framework-side-loggingyml-user-specifiable
Apr 28, 2023
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6b81126
Add KEDRO_LOGGING_CONFIG and look for logging config there
noklam 9aa1aff
Update release notes
noklam 28103da
Merge branch 'main' into 2206-make-framework-side-loggingyml-user-spe…
noklam 6dff55f
Merge branch 'main' into 2206-make-framework-side-loggingyml-user-spe…
noklam dd7cad7
update doc
noklam ab86e73
Update Release Notes
noklam 9a1b043
Trim whitespace...
noklam 5604ea5
Change to sub-section
noklam ed12fc7
Add encoding to please linting
noklam 57ad7af
Merge branch 'main' into 2206-make-framework-side-loggingyml-user-spe…
noklam 824b413
Merge branch 'main' into 2206-make-framework-side-loggingyml-user-spe…
noklam 008a465
Lint
noklam f0b99c8
Black
noklam f5381e3
Merge branch 'main' into 2206-make-framework-side-loggingyml-user-spe…
noklam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the same for Windows users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends, if you are running on bash then it should be the same. I do a quick search that we only mention
export
for a few other documentations as well. If we want to add mentions for how to make it work withCMD
we can open a new ticket to do that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine if it's consistent with how we refer to other environment variables. 👍