Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup algolia for documentation search #3007

Closed
wants to merge 5 commits into from
Closed

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Sep 4, 2023

Signed-off-by: Nok nok.lam.chan@quantumblack.com

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Fixed #2932

Setup according to: https://github.com/algolia/sphinx-docsearch

Development notes

  • Let's drop some documentations

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Copy link
Contributor Author

noklam commented Sep 5, 2023

UI is kind of working here but maybe it looks ugly. I am still figuring out how to make the index work.

https://5500-kedroorg-kedro-osrow6gr443.ws-eu104.gitpod.io/docs/build/html/index.html

image

setup.py Outdated
"docutils==0.16",
"sphinx~=5.3.0",
# "docutils==0.16",
"sphinx~=6.2.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There be dragons 🐉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the dragons, @astrojuanlu if we make this upgrade?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially some CSS breakage (sphinx, docutils, and sphinx-rtd-theme need to be upgraded at the same time).

Also, sphinx-autodoc-typehints had some problems in its newest version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good that we upgrade our DocOps toolchain. Just that it might be its own ticket if things go awry.

@noklam
Copy link
Contributor Author

noklam commented Sep 5, 2023

The current index is empty, seems to be blocked by robots.txt.

image

@astrojuanlu
Copy link
Member

The current index is empty, seems to be blocked by robots.txt.

What about https://docs.kedro.org/en/latest for instance?

@noklam
Copy link
Contributor Author

noklam commented Sep 5, 2023

image
It's not blocked but nothing is parsed either, looking into the configuration.

@noklam
Copy link
Contributor Author

noklam commented Sep 5, 2023

image

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@stichbury stichbury self-assigned this Sep 22, 2023
@stichbury
Copy link
Contributor

stichbury commented Sep 22, 2023

Queries/issues that we're dealing with at present:

  • We have to upgrade Sphinx (Need further info on what this could unleash)
  • We need some CSS customisation (solvable)
  • We seem to have to fix on one version to crawl (but we have multiple versions so is this the solution?)
  • We aren't seeing breadcrumbs or text from the page (check out search on https://quarto.org/docs/get-started/ as an example)
image

This is what we're seeing so far:

image

@stichbury
Copy link
Contributor

I've fiddled with this a bit but TBH I don't think I've had any impact whatsoever so have reverted my changes to the crawler.

I found this readthedocs/sphinx_rtd_theme#761 but it's quite old and may not be relevant.

I'm taking this off my queue now as I don't think it's a good use of my time, and we'll need to reevaluate how to proceed to get the search results optimised before handing to the website team to customise. Something to discuss with @noklam @merelcht and @astrojuanlu

@stichbury stichbury removed their assignment Sep 22, 2023
@stichbury
Copy link
Contributor

I've shared details with @SajidAlamQB and asked if he can take a look at these particular issues if time this sprint:

@SajidAlamQB
Copy link
Contributor

I tried to arrange a meeting with Algolia with help for this setup but unfortunately they aren't able to give technical advice directly. They directed us to rely on the docsearch solution.

@astrojuanlu
Copy link
Member

I just applied to the DocSearch program 👍🏽

@stichbury
Copy link
Contributor

I'm wondering if https://sphinxawesome.xyz/how-to/configure/#sec-docsearch may help us (using what the awesome-sphinx theme did to the same purpose on our theme). I'll take another look this week. https://sphinxawesome.xyz/how-to/configure/#sec-docsearch

@stichbury
Copy link
Contributor

@noklam and @SajidAlamQB Thanks for your help with this. We have agreed in #2932 to suspend this for now but potentially return in future. So I'm closing the PR.

@stichbury stichbury closed this Oct 18, 2023
@merelcht merelcht deleted the docs/setup-algolia branch November 21, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Algolia search for docs
4 participants