-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup algolia for documentation search #3007
Conversation
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
UI is kind of working here but maybe it looks ugly. I am still figuring out how to make the index work. https://5500-kedroorg-kedro-osrow6gr443.ws-eu104.gitpod.io/docs/build/html/index.html |
setup.py
Outdated
"docutils==0.16", | ||
"sphinx~=5.3.0", | ||
# "docutils==0.16", | ||
"sphinx~=6.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There be dragons 🐉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the dragons, @astrojuanlu if we make this upgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially some CSS breakage (sphinx, docutils, and sphinx-rtd-theme need to be upgraded at the same time).
Also, sphinx-autodoc-typehints had some problems in its newest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good that we upgrade our DocOps toolchain. Just that it might be its own ticket if things go awry.
What about |
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Queries/issues that we're dealing with at present:
This is what we're seeing so far: |
I've fiddled with this a bit but TBH I don't think I've had any impact whatsoever so have reverted my changes to the crawler. I found this readthedocs/sphinx_rtd_theme#761 but it's quite old and may not be relevant. I'm taking this off my queue now as I don't think it's a good use of my time, and we'll need to reevaluate how to proceed to get the search results optimised before handing to the website team to customise. Something to discuss with @noklam @merelcht and @astrojuanlu |
I've shared details with @SajidAlamQB and asked if he can take a look at these particular issues if time this sprint:
|
I tried to arrange a meeting with Algolia with help for this setup but unfortunately they aren't able to give technical advice directly. They directed us to rely on the docsearch solution. |
I just applied to the DocSearch program 👍🏽 |
I'm wondering if https://sphinxawesome.xyz/how-to/configure/#sec-docsearch may help us (using what the awesome-sphinx theme did to the same purpose on our theme). I'll take another look this week. https://sphinxawesome.xyz/how-to/configure/#sec-docsearch |
@noklam and @SajidAlamQB Thanks for your help with this. We have agreed in #2932 to suspend this for now but potentially return in future. So I'm closing the PR. |
Signed-off-by: Nok nok.lam.chan@quantumblack.com
Description
Fixed #2932
Setup according to: https://github.com/algolia/sphinx-docsearch
Development notes
Checklist
RELEASE.md
file