Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add-on test to parse pyproject.toml #3230

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Oct 25, 2023

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Related to #3169 - #3169 (comment)

It catches a bug that when using the combination of [2,3,4], an invalid configuration is created.

[tool.coverage.report]
fail_under = 0
show_missing = true
exclude_lines = ["pragma: no cover", "raise NotImplementedError"]

docs = [
    "docutils<0.18.0",
    "sphinx~=3.4.3",
    "sphinx_rtd_theme==0.5.1",
    "nbsphinx==0.8.1",
    "sphinx-autodoc-typehints==1.11.1",
    "sphinx_copybutton==0.3.1",
    "ipykernel>=5.3, <7.0",
    "Jinja2<3.1.0",
    "myst-parser~=0.17.2",
]

@SajidAlamQB @merelcht

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam noklam changed the base branch from main to develop October 25, 2023 17:44
@noklam noklam mentioned this pull request Nov 1, 2023
7 tasks
@noklam
Copy link
Contributor Author

noklam commented Nov 1, 2023

I'll change this to merge into #3228 instead of developso it won't be blocked.

@noklam noklam changed the base branch from develop to noklam/viz-add-on November 1, 2023 11:30
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
@noklam noklam marked this pull request as ready for review November 1, 2023 11:31
@noklam noklam requested a review from merelcht as a code owner November 1, 2023 11:31
@noklam noklam merged commit 78419fa into noklam/viz-add-on Nov 1, 2023
2 of 4 checks passed
@noklam noklam deleted the noklam/enhance-starter-test branch November 1, 2023 11:31
noklam added a commit that referenced this pull request Nov 3, 2023
* adapt pyspark add-ons

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* fix promopt

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* fix minor stuff in prompt

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* refactor utils and fix template switch to starters

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* lint

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* Refactor utils.py use toml and unstrip pyproject.toml and requirements.txt

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* fix broken test missing options 7

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* add more test

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* fix test

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* attempt to fix tests

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* fix test

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* remove reporting when viz selected

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* update tests for viz add-on

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* remove reporting.yml and update tests

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* add comment to _get_expected_files number counts

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* Update tests to parse pyprojec.toml (#3230)

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>

* Add .gitkeep for conf/local/

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* Fix tests

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* add comments for more context

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* More descriptive variable names

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* changes based on review - use patterns to remove parameter files

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* changes based on review cleaner template switching with more comments

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* add full stop to comment (nit)

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* Replace anyconfig with toml for tests

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>

* add docstrings

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

* add docstrings to helper methods and make them private

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* update docstring

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* changes based on review

Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>

* lint

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>

---------

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
Co-authored-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant