Minor tech debts #3429
Merged
Minor tech debts #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com>
12 tasks
DimedS
requested review from
lrcouto,
SajidAlamQB and
ankatiyar
and removed request for
merelcht
lrcouto
approved these changes
Dec 15, 2023
SajidAlamQB
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
This is some awesome refactoring and simplification, thank you @DimedS its looking a lot cleaner now! 🔥
SajidAlamQB
reviewed
Dec 18, 2023
| @@ -666,12 +625,13 @@ def _make_cookiecutter_context_for_prompts(cookiecutter_dir: Path): | |||
| return cookiecutter_context.get("cookiecutter", {}) | |||
|
|
|||
|
|
|||
| def _make_cookiecutter_args( | |||
| def _make_cookiecutter_args_and_fetch_template( | |||
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes few issues from #3264:
4:
6:
centralising all regex checks in _validate_regex() func
And lines 433-439 were removed as they were deemed unnecessary (modified return to {} instead of None in line 337 to make it possible)
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile