-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Airflow AWS MWAA deployment docs #3860
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
272c51e
Update airflow MWAA deployment docs
DimedS 9fa15c4
Linting
DimedS aeb0110
DAG Modification
DimedS 3b3b198
Apply suggestions from code review
DimedS 898939d
Merge branch 'main' into kedro-airflow-docs-deployment-cloud-providers
DimedS 8ebe270
Merge branch 'main' into kedro-airflow-docs-deployment-cloud-providers
DimedS 62c917f
PR comments
DimedS 36a64a6
Fix credentials
DimedS 65c2771
Apply suggestions from code review
DimedS 4593bdd
Fix comments
DimedS a3e4f5c
Add introduction
DimedS bc2d40e
Update docs/source/deployment/airflow.md
DimedS 634c5a1
Merge branch 'main' into kedro-airflow-docs-deployment-cloud-providers
DimedS b4ce977
Merge branch 'main' into kedro-airflow-docs-deployment-cloud-providers
DimedS e3d38f1
Update README.md
DimedS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried this yet, but do the credentials in the
local/credentials.yml
work on the cloud platform? This file ideally shouldn't be uploaded to the cloud at all. Maybe setting up env variables?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that approach with the
local
environment, and it works. We can change the environment fromlocal
toprod
, but am I correct in understanding that there isn't a big difference?For setting environment variables, I am using an
env_var.sh
file that is located in the same S3 bucket as theconf
folder, which is currently packed intoplugins.zip
. Therefore, I don't think it makes much sense to use environment variables for security reasons because, ultimately, they will be stored in the same S3 bucket. However, this S3 bucket is secure and does not have public access, so I think it's not a problem.