Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings to micropkg CLI + docs #3873

Merged
merged 5 commits into from
May 21, 2024

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented May 16, 2024

Description

Closes #3854

Development notes

  • Added deprecation notice to all micropkg CLI commands and at top-level when running kedro
  • Added deprecation notice to micropkg docs + CLI docs
  • Did not add a deprecation notice at import level of kedro.framework.cli.micropkg, since the only public method safe_extract: https://github.com/kedro-org/kedro/blob/main/kedro/framework/cli/micropkg.py#L393 is a utility method that doesn't contain any kedro specific info.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht self-assigned this May 16, 2024
@merelcht merelcht marked this pull request as ready for review May 17, 2024 09:32
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht removed the request for review from yetudada May 17, 2024 15:18
Copy link
Contributor

@lrcouto lrcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merelcht merelcht merged commit 9154378 into main May 21, 2024
41 checks passed
@merelcht merelcht deleted the deprecate-micropackaging branch May 21, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate micropackaging
3 participants