Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty printing catalog #3990

Merged
merged 48 commits into from
Jul 18, 2024
Merged

Conversation

ElenaKhaustova
Copy link
Contributor

@ElenaKhaustova ElenaKhaustova commented Jul 4, 2024

Description

Solves #3981

This PR is done on top of #3987

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
@ElenaKhaustova ElenaKhaustova changed the base branch from main to feature/3980-pretty-printing-dataset July 4, 2024 18:14
@ElenaKhaustova ElenaKhaustova changed the base branch from feature/3980-pretty-printing-dataset to main July 4, 2024 18:15
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
@astrojuanlu
Copy link
Member

Petty thing 🙏🏼 But could you attach screenshots of how this looks on VS Code notebooks, Jupyter Notebook 7.0+, and IPython?

kedro/io/cached_dataset.py Outdated Show resolved Hide resolved
@ElenaKhaustova
Copy link
Contributor Author

Petty thing 🙏🏼 But could you attach screenshots of how this looks on VS Code notebooks, Jupyter Notebook 7.0+, and IPython?

Sure, as soon as #3987 is done

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
…-pretty-printing-catalog

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
@ElenaKhaustova
Copy link
Contributor Author

Petty thing 🙏🏼 But could you attach screenshots of how this looks on VS Code notebooks, Jupyter Notebook 7.0+, and IPython?

Sure, as soon as #3987 is done

catalog and catalog.datasets give the same representation:

  • IPython
    Screenshot 2024-07-09 at 19 51 23

  • Jupyter Notebook 7.0+
    Screenshot 2024-07-09 at 19 55 24

  • VS Code notebooks
    Screenshot 2024-07-09 at 19 56 38

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
@ElenaKhaustova ElenaKhaustova marked this pull request as draft July 15, 2024 10:30
@ElenaKhaustova ElenaKhaustova marked this pull request as ready for review July 15, 2024 12:46
kedro/io/cached_dataset.py Outdated Show resolved Hide resolved
kedro/io/core.py Outdated Show resolved Hide resolved
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ElenaKhaustova ElenaKhaustova merged commit e2b20a4 into main Jul 18, 2024
41 checks passed
@ElenaKhaustova ElenaKhaustova deleted the feature/3981-pretty-printing-catalog branch July 18, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants