Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/2011-12-18.mkd.t started to fail (with newer Markdent?) #13

Open
eserte opened this issue Nov 25, 2019 · 4 comments
Open

t/2011-12-18.mkd.t started to fail (with newer Markdent?) #13

eserte opened this issue Nov 25, 2019 · 4 comments

Comments

@eserte
Copy link
Contributor

eserte commented Nov 25, 2019

t/2011-12-18.mkd.t started to fail on my smoker systems:

Can't parse allowfullscreen - not a properly formed attribute string
# Looks like your test exited with 2 before it could output anything.
t/2011-12-18.mkd.t ....................
Dubious, test returned 2 (wstat 512, 0x200)
Failed 1/1 subtests

Statistical analysis suggests that the problem happens if Markdent 0.35 is installed (@autarch: FYI):

****************************************************************
Regression 'mod:Markdent'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           1.0000          0.0216      46.25
[1='eq_0.28']         0.0000          0.0530       0.00
[2='eq_0.29']        -0.0556          0.0270      -2.06
[3='eq_0.30']         0.0000          0.0229       0.00
[4='eq_0.31']         0.0000          0.0405       0.00
[5='eq_0.32']         0.0000          0.0261       0.00
[6='eq_0.33']         0.0000          0.0299       0.00
[7='eq_0.34']         0.0000          0.0248       0.00
[8='eq_0.35']        -1.0000          0.0248     -40.37

R^2= 0.966, N= 211, K= 9
****************************************************************
@autarch
Copy link
Contributor

autarch commented Nov 26, 2019

This is a bug in Markdent. I'll fix it.

autarch added a commit to houseabsolute/Markdent that referenced this issue Nov 26, 2019
autarch added a commit to houseabsolute/Markdent that referenced this issue Nov 26, 2019
@potatogim
Copy link
Contributor

potatogim commented May 20, 2020

IMHO, we need some more updates to resolve this issue.

I opened new PR(#14) for that.

@eserte, @keedi, @autarch: Could you please make some time for this PR? :)

@autarch
Copy link
Contributor

autarch commented May 20, 2020

This was fixed in Markdent v0.36 released back in November of 2019.

@potatogim
Copy link
Contributor

potatogim commented May 20, 2020

This was fixed in Markdent v0.36 released back in November of 2019.

Yep, Thanks! I have tested this issue with Markdent v0.36 but cannot pass this test.

But it seems work with PR #14 :)

In my guess, it is caused by Markdown::Pod::Handler.

Thanks again for review it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants