New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugzilla:1950614 for Fedora packages #603
Comments
Hey @jatin-cbs I read through the linked bugzilla issue, but I'm not sure what Mock is, or how you would want me to make the configuration script "more friendly" to that tool. Can you please advise? (Sorry for the delayed reply, I'm just finishing up exams for my final semester of school.) |
Mock it is a systemd-nspawn container for building software on Fedora/RHEL/CentOS. |
@keeferrourke I personally think rpm has its own logo as artem pointed out on the bugzilla. Example of such icons - It refers to RPM meters in cars. It will eliminate the need of different fedora red hat configuration. Also it will be a standard rpm icon in the style of la-capitaine mimetypes. I don't think there is any other configuration differences between the two distros for the icon theme. |
Ok so @jatin-cbs what exactly is the issue here? Is it that you want me to change the configuration script (if so, in what way?), or is it that my mimetypes should be using a different (default but configurable? non-configurable?) icon for RPMs? |
Follow-up question: Where are these example mimetype icons from? Are they displaying an official logo, or is this artistic license? At least according to Wikipedia / rpm.org, this appears to be the official logo for the package manager. |
The issue that there is different configuration for fedora and redhat, and configuration script won't be able to run in mock as stated. I can ask artem for configuration file changes. However we think that its more practical to simply change the .rpm mimetype logo to something more standard rather than fedora / redhat logos/ suse. These icons are from Qogir and white sur theme respectively. they are artistic not official logo but inspired from the standard official rpm logo that is on the wikipedia which resembles an rpm meter. |
Okay thanks. I'm hesitant to remove the customization options for these mimetypes, but I'd be happy to add a different default RPM mimetype icon that closely resembles the official RPM logo, then still allow for the configuration script to overwrite this with distro-specific icons. @jatin-cbs I'll link this issue in a PR later today, and tag you for review to make sure it's an ok solution for the bugzilla bug. |
@keeferrourke Distro logos are creative way and some people do like it. So Yes I agree. We can change default rpm icons to a new standard one and still keep distro specific rpm configuration.
Currently these are directly / indirectly linked to |
#605 Should address the immediate issue of RedHat branding showing up in Fedora. I'm still unsure why the configure script isn't compatible with the Mock tool though, and how this causes possible packaging issues. I'd like to make this easy to package, so @jatin-cbs @tim77 let's talk about possible changes to the configuration script in a new issue. Feel free to open a new bug at your leisure. All the best! |
Its settled and i don't think any changes are necessary. |
Alright #605 is merged to master! Thanks all! |
@tim77 FYI, I just cut a new release (first time in >2 years 😳) |
Great! 👍 I would like if we switch to releases instead of git snapshots TBH. Not a big issue, but this more practical. |
https://bugzilla.redhat.com/show_bug.cgi?id=1950614
The issue is, Redhat configuration is currently the default in the icon theme. We can't run configuration file in mock. And manually running configuration and using it as source will cause this to be done every single time for all supported Fedora releases.
Possible solutions -
The text was updated successfully, but these errors were encountered: