Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugzilla:1950614 for Fedora packages #603

Closed
shuriken1812 opened this issue Apr 19, 2021 · 14 comments
Closed

Bugzilla:1950614 for Fedora packages #603

shuriken1812 opened this issue Apr 19, 2021 · 14 comments
Labels

Comments

@shuriken1812
Copy link

shuriken1812 commented Apr 19, 2021

https://bugzilla.redhat.com/show_bug.cgi?id=1950614

The issue is, Redhat configuration is currently the default in the icon theme. We can't run configuration file in mock. And manually running configuration and using it as source will cause this to be done every single time for all supported Fedora releases.

Possible solutions -

  1. Making the script more Mock friendly.
  2. Making Fedora configuration the default.
  3. Having different branch for Fedora configuration which we can use as the source in package build.
@keeferrourke
Copy link
Owner

Hey @jatin-cbs I read through the linked bugzilla issue, but I'm not sure what Mock is, or how you would want me to make the configuration script "more friendly" to that tool. Can you please advise?

(Sorry for the delayed reply, I'm just finishing up exams for my final semester of school.)

@tim77
Copy link
Contributor

tim77 commented Apr 23, 2021

Mock it is a systemd-nspawn container for building software on Fedora/RHEL/CentOS.

@shuriken1812
Copy link
Author

@keeferrourke I personally think rpm has its own logo as artem pointed out on the bugzilla.

Example of such icons -

Screenshot from 2021-04-23 22-54-37
Screenshot from 2021-04-23 22-57-55

It refers to RPM meters in cars. It will eliminate the need of different fedora red hat configuration. Also it will be a standard rpm icon in the style of la-capitaine mimetypes. I don't think there is any other configuration differences between the two distros for the icon theme.

@keeferrourke
Copy link
Owner

Ok so @jatin-cbs what exactly is the issue here?

Is it that you want me to change the configuration script (if so, in what way?), or is it that my mimetypes should be using a different (default but configurable? non-configurable?) icon for RPMs?

@keeferrourke
Copy link
Owner

Follow-up question: Where are these example mimetype icons from? Are they displaying an official logo, or is this artistic license?

At least according to Wikipedia / rpm.org, this appears to be the official logo for the package manager.

@shuriken1812
Copy link
Author

shuriken1812 commented Apr 23, 2021

The issue that there is different configuration for fedora and redhat, and configuration script won't be able to run in mock as stated. I can ask artem for configuration file changes. However we think that its more practical to simply change the .rpm mimetype logo to something more standard rather than fedora / redhat logos/ suse.

These icons are from Qogir and white sur theme respectively. they are artistic not official logo but inspired from the standard official rpm logo that is on the wikipedia which resembles an rpm meter.

@keeferrourke
Copy link
Owner

Okay thanks. I'm hesitant to remove the customization options for these mimetypes, but I'd be happy to add a different default RPM mimetype icon that closely resembles the official RPM logo, then still allow for the configuration script to overwrite this with distro-specific icons.

@jatin-cbs I'll link this issue in a PR later today, and tag you for review to make sure it's an ok solution for the bugzilla bug.

@shuriken1812
Copy link
Author

shuriken1812 commented Apr 23, 2021

@keeferrourke Distro logos are creative way and some people do like it. So Yes I agree.

We can change default rpm icons to a new standard one and still keep distro specific rpm configuration.

rpm.svg , application-x-rpm.svg , gnome-mime-application-x-rpm.svg , application-x-source-rpm.svg

Currently these are directly / indirectly linked to application-x-rpm-redhat.svg by default.

keeferrourke added a commit that referenced this issue Apr 23, 2021
This should close issue #602 and #603.

The default RPM mimetype now lacks any distribution-specific branding,
and instead uses a generic icon based on the official rpm.org logo.

Users can still run the configuration script to get
distribution-specific mimetype icons for their package files.
@keeferrourke
Copy link
Owner

#605 Should address the immediate issue of RedHat branding showing up in Fedora. I'm still unsure why the configure script isn't compatible with the Mock tool though, and how this causes possible packaging issues.

I'd like to make this easy to package, so @jatin-cbs @tim77 let's talk about possible changes to the configuration script in a new issue. Feel free to open a new bug at your leisure.

All the best!

@shuriken1812
Copy link
Author

shuriken1812 commented Apr 23, 2021

Its settled and i don't think any changes are necessary.
Everything that can be done in mock can be done without mock. Mock runs rpmbuild in an isolated environment consisting of a minimal set of packages. Those package don't include what it requires to see the distribution logo. If artem run rpmbuild on his own system it will build the package without any issue. Its nothing wrong about the config script. See Mock as just a fedora container with very minimal packages or chroot which may not satisfy everything 👍

@tim77
Copy link
Contributor

tim77 commented Apr 24, 2021

I hope i fixed or at least improved current build in Fedora but need to test (f34 only for now). At least distro vendor should configured correctly.

This is partial fix for RH#1950614 since we wait for #605 merged.

keeferrourke added a commit that referenced this issue Apr 24, 2021
This should close issue #602 and #603.

The default RPM mimetype now lacks any distribution-specific branding,
and instead uses a generic icon based on the official rpm.org logo.

Users can still run the configuration script to get
distribution-specific mimetype icons for their package files.
@keeferrourke
Copy link
Owner

Alright #605 is merged to master! Thanks all!

@keeferrourke
Copy link
Owner

@tim77 FYI, I just cut a new release (first time in >2 years 😳)

@tim77
Copy link
Contributor

tim77 commented Apr 25, 2021

@tim77 FYI, I just cut a new release (first time in >2 years flushed)

Great! 👍 I would like if we switch to releases instead of git snapshots TBH. Not a big issue, but this more practical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants