Root out NS_ERROR_FAILURE in nsIDOM* [mediabistro, others]

[GoogleCodeExporter]

The optimized DOM in 9.0.4 is throwing _FAILUREs, probably related to a
similar issue I already fixed (see
http://code.google.com/p/classilla/issues/detail?id=59#c4 ). This one is
http://www.mediabistro.com/webnewser/cnncom/preview_of_the_new_cnncom_141061.asp
NS_ERROR_FAILURE nsIDOMScreen.width
edge.quantserve.com/quant.js

We should go through all of the DOM pieces and make sure that we're not
returning FAILUREs for properties that don't yet exist. This is technically
a regression although the test case page doesn't display in 9.0 either with
JavaScript on.

Original issue reported on code.google.com by classi...@floodgap.com on 23 Oct 2009 at 5:27

• Blocked on: Progress tracker: Layout transplant for 9.3 #1

[GoogleCodeExporter]

It's also hard to call this a regression from Mozilla 1.3.1, because the test 
case
simply crashes.

Original comment by classi...@floodgap.com on 23 Oct 2009 at 5:32

[GoogleCodeExporter]

A few minutes in the debugger shows that nsPresContext.cpp has a null 
mDeviceContext.

Original comment by classi...@floodgap.com on 23 Oct 2009 at 5:44

[GoogleCodeExporter]

Next step is to add some code in DocumentViewerImpl::Init so we can throw a
breakpoint if aDeviceContext is null (content/nsDocumentViewer.cpp). Something 
like

if (aDeviceContext) {
NS_ASSERTION(!aDeviceContext, "crapola");
}

should suffice.

Original comment by classi...@floodgap.com on 23 Oct 2009 at 5:59

[GoogleCodeExporter]

I'm not seeing this much in the overflow branch, so I am downgrading to medium.

Original comment by classi...@floodgap.com on 30 Jan 2010 at 7:06

• Added labels: Priority-Medium
• Removed labels: Priority-High

[GoogleCodeExporter]

Original comment by classi...@floodgap.com on 23 May 2010 at 9:47