Skip to content

Commit

Permalink
closed local sockets after each request to avoid "ResourceWarning: un…
Browse files Browse the repository at this point in the history
…closed socket" in python 3
  • Loading branch information
keenhenry committed Aug 17, 2014
1 parent ac99e92 commit 7415da0
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions pda/listdb/ListDB.py
Expand Up @@ -198,19 +198,22 @@ def _get_one_label(self, name, color, labels):
"""

resp = requests.get(self.url_labels+'/'+name, auth=self.auth)
resp.connection.close()

if resp.status_code == requests.codes.ok: # label found
labels.append(name)
else: # label not found, create a new label in Github Issues
rep = requests.put(self.url_labels,
data=json.dumps({'name': name, 'color': color}),
auth=self.auth)
rep.connection.close()

if rep.status_code == requests.codes.created:
labels.append(name)
else:
die_msg(PROG_NAME, 'label created failed: ' + name)


def _update_labels(self, cmd):
"""update **Github Issues** based on the information given by `cmd`
:param cmd: dict
Expand All @@ -222,6 +225,7 @@ def _update_labels(self, cmd):

resp = requests.get(self.url_issues+'/'+str(issue_number)+'/labels',
auth=self.auth)
resp.connection.close()

if resp.status_code == requests.codes.ok:
# replacing labels
Expand All @@ -248,6 +252,7 @@ def _update_labels(self, cmd):
die_msg(PROG_NAME, \
'failed to retrive labels for current issue: '+str(issue_number))


return labels

def _get_labels(self, cmd):
Expand Down Expand Up @@ -279,6 +284,7 @@ def _get_milestone_number(self, cmd):
# look for existing milestone
if milestone_title:
resp = requests.get(self.url_milestones, auth=self.auth)
resp.connection.close()

if resp.status_code == requests.codes.ok:
for milestone in resp.json():
Expand All @@ -293,6 +299,7 @@ def _get_milestone_number(self, cmd):
resp = requests.post(url=self.url_milestones,
data=json.dumps({'title': milestone_title}),
auth=self.auth)
resp.connection.close()

if resp.status_code == requests.codes.created:
milestone_number = resp.json()['number']
Expand Down Expand Up @@ -354,16 +361,19 @@ def _exec_cmd_on_remote(self, cmd):
data=json.dumps(payload),
auth=self.auth)
success = (resp.status_code == requests.codes.created)
resp.connection.close()
elif cmd['CMD'] == 'EDIT':
resp = requests.patch(url=url,
data=json.dumps(payload),
auth=self.auth)
success = (resp.status_code == requests.codes.ok)
resp.connection.close()
else: # REMOVE
resp = requests.patch(url=url,
data=json.dumps(payload),
auth=self.auth)
success = (resp.status_code == requests.codes.ok)
resp.connection.close()

return success

Expand Down Expand Up @@ -433,6 +443,7 @@ def sync_local_dbstore(self):
resp = requests.get(self.url_issues,
params={'state': 'open'},
auth=self.auth)
resp.connection.close()

if resp.status_code == requests.codes.ok:
# write issue data into local db store
Expand Down

0 comments on commit 7415da0

Please sign in to comment.