Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code standards #141

Merged
merged 8 commits into from
Nov 24, 2020
Merged

Fix code standards #141

merged 8 commits into from
Nov 24, 2020

Conversation

niektenhoopen
Copy link
Contributor

@niektenhoopen niektenhoopen commented Nov 20, 2020 •
edited

edit:

  • Update PHPUnit to v9 is not possible because the package still supports PHP 5.6. It has no extra functional benefit other than being up-to-date with current versions. Therefore I decided to revert the update to v9.

@niektenhoopen niektenhoopen changed the title Fix code standards, update PHPUnit Fix code standards Nov 23, 2020
@niektenhoopen
Copy link
Contributor Author

@piotrek-buchman @kmfk Could you please merge this? This should also close #138

@piotrek-buchman
Copy link
Contributor

@niektenhoopen thanks for this PR. LGTM

@piotrek-buchman piotrek-buchman merged commit 581d1bc into keenlabs:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@niektenhoopen @piotrek-buchman @simondotwhite