Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move php_codesniffer to dev dependencies #144

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

stof
Copy link
Contributor

@stof stof commented Mar 16, 2023

There is no reason to depend on it in projects using this SDK.

There is no reason to depend on it in projects using this SDK.
@stof
Copy link
Contributor Author

stof commented Mar 17, 2023

@michalpierog it would be great if you could merge this PR and tag a new release. There is really no reason to have php_codesniffer in our prod environments.

Copy link
Member

@michalpierog michalpierog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalpierog michalpierog merged commit 7a89c1b into keenlabs:master Mar 20, 2023
@stof stof deleted the patch-1 branch March 20, 2023 09:06
@michalpierog
Copy link
Member

@stof v2.8.2 is released. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants