Dropping default value for __call #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `__call` method's `$args` parameter is required and will always be present as an array (http://www.php.net/manual/en/language.oop5.overloading.php#object.call), adding a default value (like `$args = array()`) is not needed and even causes problems, as described in mockery/mockery#263. Removing this allows us to manipulate the object as expected.
|
should we add a test or even throw an exception if the array is empty? |
|
@kmfk anyway we can avoid the 15 day waiting period on that? Would you consider this a BC? and if not, should this no be a bug fix release that goes out asap? |
k-k
pushed a commit
that referenced
this pull request
Mar 17, 2014
Dropping default value for __call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__callmethod's$argsparameter is required and will always be present as an array (http://www.php.net/manual/en/language.oop5.overloading.php#object.call), adding a default value (like$args = array()) is not needed and even causes problems, as described in mockery/mockery#263.Removing this allows us to manipulate the object as expected.