Allow sending arbitrary headers for requests #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow the `:headers` option when sending a request - Adds a test for this - Clean up deprecated test syntax (remove `should` in favor of `expect`) - Suppress `stdout` during test runs to clean up test output - Bump the version number and add to the changelog.
josephwegner
suggested changes
May 2, 2017
| @@ -10,7 +10,7 @@ module PublishingMethods | |||
| # | |||
| # @return the JSON response from the API | |||
| def add_event(event_collection, properties, options={}) | |||
There was a problem hiding this comment.
can we remove the options={} here, now that it is unused?
| uri = URI.parse(url) | ||
| Keen::HTTP::Sync.new(self.api_url, self.proxy_url, self.read_timeout).get( | ||
| :path => "#{uri.path}?#{uri.query}", | ||
| :headers => api_headers(self.read_key, "sync") |
There was a problem hiding this comment.
Is there an api_headers method that can be removed now?
There was a problem hiding this comment.
No, we still use api_headers, in the request_headers function.
| @@ -20,7 +20,7 @@ def delete_url(event_collection, filter_params=nil) | |||
| it 'should not require filters' do | |||
| url = delete_url(event_collection) | |||
| stub_keen_delete(url, 204) | |||
| client.delete(event_collection).should == true | |||
| expect(client.delete(event_collection)).to be true | |||
josephwegner
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:headersoption when sending a requestshouldin favor ofexpect)stdoutduring test runs to clean up test output