Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET 3.5 version of SDK duplicates code from portable library and .NET 4.0 library. #36

Closed
baumatron opened this issue Nov 22, 2016 · 2 comments
Closed

.NET 3.5 version of SDK duplicates code from portable library and .NET 4.0 library. #36

baumatron opened this issue Nov 22, 2016 · 2 comments

Comments

@baumatron
Copy link
Contributor

The .NET 3.5 project contains what is mostly copy and pasted code from the more recent library (or vice-versa). The project should be refactored so as to not duplicate any code. CLR features not supported by 3.5 should be either removed from the new library, implemented as a component that can vary between the SDK versions, or implemented as a shim or derived class in the .NET 4/4.5/portable library.
masojus added a commit that referenced this issue Feb 24, 2017
@masojus
Add the "Keen-Sdk" HTTP Header everywhere we create a RestRequest in …
6accb57 
…the .NET3.5 lib:

- Same comments as in commit bd5ec53 as far as scattering these calls all over for now so we start getting the data, and we can centralize it later.
- Having to do this here as nearly a copy/paste of commit bd5ec53 is an example of Issue #36 which would be nice to address.
@baumatron
Copy link
Contributor Author

As part of the push for netstandard, we can eventually deprecate the .NET 3.5 library. It mainly exists to support Unity, which will be moving to support netstandard hopefully with their next release.

@masojus
Copy link
Contributor

masojus commented Nov 14, 2017

This is fixed in PR #135 with commit 96ee7b5

@masojus masojus closed this as completed Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baumatron @masojus