Chain specific balance monitor #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the changes made in `keep-common`, balance monitor is no longer a chain-agnostic concept. Because of that, this change removes it from the `chain.Handle` interface. Instead of that, each chain implementation has a possibility to decide whether it provides a balance monitor or not.
pdyraga
reviewed
Feb 25, 2021
|
@pdyraga all comments addressed! |
pdyraga
reviewed
Feb 25, 2021
pdyraga
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: keep-network/keep-common#66
According to the changes made in
keep-common, the balance monitor is no longer a chain-agnostic concept. Because of that, this change removes it from thechain.Handleinterface. Instead of that, each chain implementation has a possibility to decide whether it provides a balance monitor or not. Apart from that, we also regenerate contract bindings in order to apply changes made inkeep-commongenerators.