This repository has been archived by the owner on May 22, 2023. It is now read-only.
Call gas limit #220
Merged
Call gas limit #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pdyraga
reviewed
Feb 18, 2020
pdyraga
reviewed
Feb 18, 2020
We do not limit the gas in calls when the interested party withdraws ether. It does not make sense - the interested party knows best how much calls should cost and can set the gas limit appropriately.
Relay request should not cost more than 360k but we include a safety margin for future upgrades.
pdyraga
approved these changes
Feb 19, 2020
|
Tested and works as expected. Since I was committing here can you please double-check @nkuba? |
nkuba
reviewed
Feb 19, 2020
nkuba
approved these changes
Feb 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are limiting forwarded gas to request relay entry function to prevent malicious behavior in case the beacon service contract gets compromised. Relay request should not consume more than
360kof gas. We set the limit to400kto have a safety margin for future updates.