Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Full Rename: Rename ALL OF THE THINGS (remaining*) to keep-ecdsa #319

Merged
merged 8 commits into from
Mar 24, 2020
Merged

Full Rename: Rename ALL OF THE THINGS (remaining*) to keep-ecdsa #319

merged 8 commits into from
Mar 24, 2020

Conversation

Shadowfiend
Copy link
Contributor

@Shadowfiend Shadowfiend commented Mar 20, 2020 •
edited by sthompson22

Just infra renames here!

Loose order of operations:

  • Double check renamed files for lingering tecdsa references. Make changes where needed.

  • git mv files from tecdsa -> ecdsa filenames

  • If no keep-ecdsa (InitContainer and application) image published, rename the last keep-tecdsa image. This will prevent deployments from failing without a rebuild. We want to do this to test deployments from this branch without having to wait on builds.

  • Apply *-service configs

  • Take IPs from new services and set them in the appropriate peers configs for each ecdsa client. In the case of keep-test, we'll need to update DNS entries with new addresses.

  • Rotate keep-ecdsa StatefulSets one at a time.

  • Kill tecdsa services

keep-dev

  • Double check renamed files for lingering tecdsa references. Make changes where needed.
  • git mv files from tecdsa -> ecdsa filenames
  • keep-ecdsa image and InitContainer available (docker pull / rename / docker push)
  • Renamed services (0-4) applied to env
  • StatefulSet configs updated with new service addresses (0-4)
  • StatefulSet deployment rotation (destroy/create one at a time)
  • Remove old tecdsa Services from environment

keep-test

  • Double check renamed files for lingering tecdsa references. Make changes where needed.
  • git mv files from tecdsa -> ecdsa filenames
  • keep-ecdsa image and InitContainer available
  • Rename executable in keep-ecdsa application image locally and push to container registry.
  • Rename provisioner script for InitContainer locally and push to container registry.
  • Rename template file and config file write in provisioner script
  • Renamed services (0-4) applied to env
  • New Service addresses added to DNS entries for ecdsa clients
  • StatefulSet deployment rotation (destroy/create one at a time)
  • Remove old tecdsa Services from environment

Missing:

@Shadowfiend Shadowfiend mentioned this pull request Mar 20, 2020
Closed
@pdyraga
Copy link
Member

pdyraga commented Mar 23, 2020

Oh my, I duplicated this work in #316 🤦‍♂

@nkuba
Copy link
Member

nkuba commented Mar 23, 2020

Oh my, I missed it 🤦‍♂

@Shadowfiend Shadowfiend changed the title Full Rename: Rename ALL OF THE THINGS to keep-ecdsa Full Rename: Rename ALL OF THE THINGS (remaining*) to keep-ecdsa Mar 23, 2020
@Shadowfiend Shadowfiend changed the base branch from open-season to master March 23, 2020 14:04
@sthompson22
Copy link
Contributor

Added a rough order of operations to the description.

Remove pre-networking files
7b514ff 
In a previous PR (#308) we migrated away from using these files for
keep-ecdsa deployments.  These should have been removed in that PR.
@sthompson22
Copy link
Contributor

This PR includes only a partial rename, labels and label selectors are still using tecdsa. These will need to be updated as well. I'll do that while I'm in here.

Sloan Thompson added 3 commits March 23, 2020 15:10
Use ecdsa tags
6753591 
During the initial rename we missed the labels and labelSelectors.
Use ecdsa tags
dce9793 
During the initial rename we missed the labels and labelSelectors.
Git mv filenames
74b759f 
We've renamed all the in-file tecdsa references, here we're renaming the
files to match the updated naming.
@sthompson22
Copy link
Contributor

sthompson22 commented Mar 23, 2020 •
edited

There's an additional complication here, via the InitContainer. The provisioning script the InitContainer runs as a tecdsa reference in the script name. This impacts the command argument for the InitContainer section of each StatefulSet config file. I think I can get around this without rebuilding for keep-test by renaming the provisioning script file on a local instance of the InitContainer, saving, and pushing to the container registry.

Update Service addresses
ba25ba8 
As part of the rename we've got 5 new services for each of the ecdsa
clients.  Here we set the new Service addresses into their associated
multiaddr.
@sthompson22
Copy link
Contributor

There's an additional complication here, via the InitContainer. The provisioning script the InitContainer runs as a tecdsa reference in the script name. This impacts the command argument for the InitContainer section of each StatefulSet config file. I think I can get around this without rebuilding for keep-test by renaming the provisioning script file on a local instance of the InitContainer, saving, and pushing to the container registry.

haha, this goes one layer deeper. There's a template file referenced in the provisioning script that also has tecdsa in the name.

Sloan Thompson added 2 commits March 23, 2020 17:54
Merge branch 'master' into full-rename
2405387
Git mv filenames
41b9bed 
We've renamed all the in-file tecdsa references, here we're renaming the
files to match the updated naming.
@sthompson22 sthompson22 marked this pull request as ready for review March 23, 2020 22:54
@sthompson22
Copy link
Contributor

Alright @Shadowfiend This is ready. Worth noting keep-dev is borked until we stop the tenderly push step, so I didn't give the env the same treatment as keep-test. The deployments will clear up there on a fresh build + tenderly push disable.

@sthompson22
Copy link
Contributor

Ah, just realized Kuba needs to look at this, Antonio authored.

@sthompson22
Copy link
Contributor

@nkuba Ping, This is deployed, would prefer it doesn't linger.

@Shadowfiend
Copy link
Contributor Author

Let's have you approve the PR @sthompson22 (really it's me approving it heh) and then I'll merge.

nkuba
nkuba approved these changes Mar 24, 2020
View reviewed changes
.circleci/config.yml
cd /tmp/keep-tecdsa/contracts
gsutil -m cp * gs://${CONTRACT_DATA_BUCKET}/keep-tecdsa
cd /tmp/keep-ecdsa/contracts
gsutil -m cp * gs://${CONTRACT_DATA_BUCKET}/keep-ecdsa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update any other repos using this bucket? tbtc for instance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch: https://github.com/keep-network/tbtc/blob/b87758e91960b0f2446e5355ef422a8bfcc46910/implementation/scripts/circleci-provision-external-contracts.sh#L10

This should go away once packaging is operating properly…

@nkuba nkuba merged commit 4c0b1c1 into master Mar 24, 2020
@nkuba nkuba deleted the full-rename branch March 24, 2020 16:33
@nkuba nkuba mentioned this pull request Mar 26, 2020
Closed
@pdyraga pdyraga added this to the v0.11.0 milestone Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sthompson22 sthompson22 sthompson22 approved these changes

@nkuba nkuba nkuba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shadowfiend @pdyraga @nkuba @sthompson22