This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
CI workflows - Move cache instead of copying #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `keep-ecdsa` we've seen a number of workflows failing with `No space lefton device` error. The problem was a combination of a big cache size and significant memory allocation after building Docker image. According to moby/buildkit#1850: "At the moment caches are copied over the existing cache so it keeps growing". As a temporary fix (until issue gets fixed by GH), we introduced a step that moves the cache (similarily to how it's described in moby/buildkit#1896) instead of copying. Although we havent seen the problems with cache size yet in other projects than `keep-ecdsa`, we're applying the solution across the repositories to decrease the likelyhood of encountering problem in the future.
This was referenced Jun 16, 2021
nkuba
suggested changes
Jul 2, 2021
.github/workflows/dapp.yml
Outdated
| # https://github.com/docker/build-push-action/issues/252 | ||
| # https://github.com/moby/buildkit/issues/1896 | ||
| # Without the change some jobs were failing with `no space left on device` | ||
| name: Move cache |
There was a problem hiding this comment.
Let's move it to be the very last step.
nkuba
approved these changes
Jul 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
keep-ecdsawe've seen a number of workflows failing withNo space lefton deviceerror.The problem was a combination of a big cache size and significant memory
allocation after building Docker image.
According to moby/buildkit#1850:
"At the moment caches are copied over the existing cache so it keeps
growing".
As a temporary fix (until issue gets fixed by GH), we introduced a step
that moves the cache (similarily to how it's described in
moby/buildkit#1896) instead of copying.
Although we havent seen the problems with cache size yet in other
projects than
keep-ecdsa, we're applying the solution across therepositories to decrease the likelyhood of encountering problem in the
future.
See also:
keep-network/keep-ecdsa#822
keep-network/keep-core#2501
keep-network/tbtc#807