Add Sepolia / Optimism Sepolia support for Optimism cross-chain #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 tasks
The Goerli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that was created to replace it is called [Holešky](https://github.com/eth-clients/holesky), however it will take some time until it gets integrated with by some of the projects we rely on. As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated. Until Görli is not dead we want to support both testnets. The Goerli -> Sepolia migration means that also L2 testnet basing on Goerli (Optimism Goerli) needs to be migrated to Sepolia-based chain (Optimism Sepolia). At the moment Optimism Sepolia is not supported by Wormhole, so deployment of our contracts on that testnet is yet not possible. But we're already adding changes that prepare us for the moment when it will be supported. Once support is confirmed, we'll need to verify if `wormholeChainID` we use in the config is correct for the testnet.
michalinacienciala
force-pushed
the
sepolia-support-optimism
branch
from
d2e7f6d
to
c2a4f13
Compare
deployment
The Optimism Sepolia testnet is not on the list of chains supported by the `hardhat-verify` plugin (https://github.com/NomicFoundation/hardhat/blob/main/packages/hardhat-verify/src/internal/chain-config.ts). We're adding a custom configuration that will make the contracts verification possible on that testnet (following the https://hardhat.org/hardhat-runner/plugins/nomicfoundation-hardhat-verify#adding-support-for-other-networks docs).
Wormhole has added support for Arbitrum Sepolia, Base Sepolia and Optimism Sepolia testnets. We want to modify the config of our deployment scripts so that deployment on Sepolia-based L2s would be possible. As the Chain IDs for Wormhole Sepolia-based networks differ from from IDs for Mainnet and Goerli-based testnets, we need to set the right value of `...WormholeChainID` constant for the the right network we're deploying to.
Adding Sepolia-related contracts needed for deployment on `optimismSepolia` network: * `external/optimismSepolia/OptimismTokenBridge.json` - address taken from https://docs.wormhole.com/wormhole/blockchain-environments/evm#testnet-contracts-optimism-sepolia-11155420 * `external/optimismSepolia/SolanaWormholeGateway.json` - used the same value as in `optimismGoreli` * `external/sepolia/TokenBridge.json` - address taken from https://docs.wormhole.com/wormhole/blockchain-environments/evm#testnet-contracts-sepolia-11155111 NOT included in this commit (but needed for the deployment): * `external/optimismSepolia/OptimismWormholeTBTC.json` - in order to get the address we need to perform attestation of the Ethereum Sepolia TBTC token on Optimism Sepolia (but atm Optimism Sepolia is not available on the list of target networks on https://wormhole-foundation.github.io/example-token-bridge-ui/#/register)
Open
17 tasks
Locally deployed portal was used to register TBTC.
We're adding artifacts for contracts deployed to Optimism Sepolia network.
We were using wrong condition for computation of wormholeChainID. As a result, we've been associating Gateway Address with wrong chain. We've run the `12_update_self_in_wormhole_gateway_mapping.ts` script once more and got new deployment artifact.
Some dependencies were missing.
We were using wrong condition for computation of wormholeChainID. As a result, we've been associating Gateway Address with wrong chains.
lukasz-zimnoch
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Goerli testnet currently used by Threshold/Keep for development purposes was planned to become deprecated with the end of year 2023. Although it's already 2024, the testnet is still live, but it will loose validators over the time and may become unusable at some point. The testnet that was created to replace it is called
Holešky, however it will take some time until it gets integrated with by some of the projects we rely on. As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated.
The Goerli -> Sepolia migration means that also L2 testnet based on Goerli (Optimism Goerli) needs to be migrated to Sepolia-based chain (Optimism Sepolia). In this PR we're adjusting the config used to deploy testnet contracts in the
@keep-network/tbtc-v2-arbitrumproject. After the update, both deploy tooptimismGoerliandoptimismSepolianetworks will be supported (we may removeoptimismGoerlisupport once we're sure theoptimismSepoliadeployment works as expected).TODO
external/optimismSepolia/OptimismWormholeTBTC.json- in order to get the address we need to perform attestation of the Ethereum Sepolia TBTC token on Optimism Sepolia (but atm Optimism Sepolia is not available on the list of target networks on https://wormhole-foundation.github.io/example-token-bridge-ui/#/register)Ref: threshold-network/solidity-contracts#150